Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(596)

Issue 9303050: code review 9303050: cmd/gc: repair make(T) in export data for inlining. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by remyoudompheng
Modified:
10 years, 10 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

cmd/gc: repair make(T) in export data for inlining. When T was an unexported type it could be forgotten. Fixes issue 5470.

Patch Set 1 #

Patch Set 2 : diff -r 0d28fd55e721 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0d28fd55e721 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0d28fd55e721 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M src/cmd/gc/export.c View 1 1 chunk +4 lines, -1 line 0 comments Download
A test/fixedbugs/issue5470.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
A test/fixedbugs/issue5470.dir/a.go View 1 1 chunk +27 lines, -0 lines 0 comments Download
A test/fixedbugs/issue5470.dir/b.go View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 10 months ago (2013-05-16 06:03:08 UTC) #1
bradfitz
LGTM On Wed, May 15, 2013 at 11:03 PM, <remyoudompheng@gmail.com> wrote: > Reviewers: golang-dev1, > ...
10 years, 10 months ago (2013-05-16 06:49:49 UTC) #2
remyoudompheng
10 years, 10 months ago (2013-05-16 07:01:56 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=9a73efa2cd4e ***

cmd/gc: repair make(T) in export data for inlining.

When T was an unexported type it could be forgotten.

Fixes issue 5470.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/9303050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b