code review 92790043: net/http/httputil: tell people not to use ClientConn an...

net/http/httputil: tell people not to use ClientConn and ServerConn

A very smart developer at Gophercon just asked me to help debug
a problem and I was horrified to learn that he was using httputil's
ClientConn. I forgot ClientConn and ServerConn were even included
in Go 1! They should've been deleted.

Scare people away from using them. The net/http package does
not use them and they're unused, unmaintained and untouched in
4+ years.

[bradfitz, 2014-04-26 20:26:22]

Hello r@golang.org, adg@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2014-04-26 21:17:29]

LGTM

https://codereview.appspot.com/92790043/diff/40001/src/pkg/net/http/httputil/...
File src/pkg/net/http/httputil/persist.go (right):

https://codereview.appspot.com/92790043/diff/40001/src/pkg/net/http/httputil/...
src/pkg/net/http/httputil/persist.go:34: // ServerConn is low-level and old.
Applications should use Server in
s/use/instead &/

https://codereview.appspot.com/92790043/diff/40001/src/pkg/net/http/httputil/...
src/pkg/net/http/httputil/persist.go:51: // ServerConn is low-level and old.
Applications should use Server in
ditto

https://codereview.appspot.com/92790043/diff/40001/src/pkg/net/http/httputil/...
src/pkg/net/http/httputil/persist.go:227: // ClientConn is low-level and old.
Applications should use Client or
ditto

https://codereview.appspot.com/92790043/diff/40001/src/pkg/net/http/httputil/...
src/pkg/net/http/httputil/persist.go:245: // ClientConn is low-level and old.
Applications should use Client or
ditto

https://codereview.appspot.com/92790043/diff/40001/src/pkg/net/http/httputil/...
src/pkg/net/http/httputil/persist.go:263: // Transport in the net/http package.
s/.$/ instead./

[bradfitz, 2014-04-27 05:14:42]

*** Submitted as https://code.google.com/p/go/source/detail?r=d602b3f93a3a ***

net/http/httputil: tell people not to use ClientConn and ServerConn

A very smart developer at Gophercon just asked me to help debug
a problem and I was horrified to learn that he was using httputil's
ClientConn. I forgot ClientConn and ServerConn were even included
in Go 1! They should've been deleted.

Scare people away from using them. The net/http package does
not use them and they're unused, unmaintained and untouched in
4+ years.

LGTM=r
R=r, adg
CC=golang-codereviews
https://codereview.appspot.com/92790043

[dgryski, 2014-04-30 08:44:24]

On Sunday, April 27, 2014 7:14:42 AM UTC+2, Brad Fitzpatrick wrote:
> 
> net/http/httputil: tell people not to use ClientConn and ServerConn
> 


Should there be a bug filed to delete these for Go2 ?

Damian 

[adg, 2014-04-30 14:09:55]

On 30 April 2014 02:44, <dgryski@gmail.com> wrote:

> Should there be a bug filed to delete these for Go2 ?


Sure, why not.

[vieux, 2014-05-01 00:55:17]

Hi, is it possible to do http over unix socket without httputil.ClientConn ?

[kisielk, 2014-05-01 12:05:44]

On 2014/05/01 00:55:17, vieux wrote:
> Hi, is it possible to do http over unix socket without httputil.ClientConn ?

You can set your own dial function on http.Transport, but this probably isn't
the place to discuss it if you need more help than that.