Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(160)

Issue 9274043: code review 9274043: effective_go.html: be more accepting in the guidelines ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by r
Modified:
10 years, 10 months ago
Reviewers:
CC:
golang-dev, bradfitz, adg
Visibility:
Public.

Description

effective_go.html: be more accepting in the guidelines for interface names Fixes issue 5421.

Patch Set 1 #

Patch Set 2 : diff -r 1638d2adb665 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M doc/effective_go.html View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 10 months ago (2013-05-07 18:24:41 UTC) #1
bradfitz
LGTM On Tue, May 7, 2013 at 11:24 AM, <r@golang.org> wrote: > Reviewers: golang-dev1, > ...
10 years, 10 months ago (2013-05-07 18:33:27 UTC) #2
adg
LGTM
10 years, 10 months ago (2013-05-07 18:34:51 UTC) #3
r
10 years, 10 months ago (2013-05-07 18:41:41 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=bbe324079abe ***

effective_go.html: be more accepting in the guidelines for interface names
Fixes issue 5421.

R=golang-dev, bradfitz, adg
CC=golang-dev
https://codereview.appspot.com/9274043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b