Issue 92720045: code review 92720045: sync: detect incorrect usages of RWMutex

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 92720045: code review 92720045: sync: detect incorrect usages of RWMutex (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by dvyukov

Modified:
9 years, 10 months ago

Reviewers:
ruiu

CC:
ruiu, golang-codereviews

Visibility:
Public.

Description

sync: detect incorrect usages of RWMutex Fixes issue 7858.

Patch Set 2 : diff -r f613443bb13a https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 3

Patch Set 3 : diff -r 9ca1e1d70060 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 9ca1e1d70060 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -1 line)			Patch
	M	src/pkg/sync/rwmutex.go	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
	M	src/pkg/sync/rwmutex_test.go	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ruiu

https://codereview.appspot.com/92720045/diff/20001/src/pkg/sync/rwmutex.go File src/pkg/sync/rwmutex.go (right): https://codereview.appspot.com/92720045/diff/20001/src/pkg/sync/rwmutex.go#newcode56 src/pkg/sync/rwmutex.go:56: raceEnable() Need to enclose it with if raceenabled {}? ...

10 years ago (2014-05-09 16:34:46 UTC) #1

dvyukov

10 years ago (2014-05-10 05:32:42 UTC) #2

dvyukov

Hello ruiu@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

9 years, 10 months ago (2014-06-20 05:07:59 UTC) #3

dvyukov

9 years, 10 months ago (2014-06-20 05:20:02 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=e0ad7e329637 ***

sync: detect incorrect usages of RWMutex
Fixes issue 7858.

LGTM=ruiu
R=ruiu
CC=golang-codereviews
https://codereview.appspot.com/92720045

Expand All Messages | Collapse All Messages