Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1848)

Issue 92630044: code review 92630044: go.blog: add "GopherCon 2014 Wrap Up" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by adg
Modified:
9 years, 11 months ago
Reviewers:
r, dave
CC:
r, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

go.blog: add "GopherCon 2014 Wrap Up"

Patch Set 1 #

Patch Set 2 : diff -r bfa8608b2028 https://code.google.com/p/go.blog #

Total comments: 2

Patch Set 3 : diff -r bfa8608b2028 https://code.google.com/p/go.blog #

Patch Set 4 : diff -r bfa8608b2028 https://code.google.com/p/go.blog #

Patch Set 5 : diff -r bfa8608b2028 https://code.google.com/p/go.blog #

Patch Set 6 : diff -r bfa8608b2028 https://code.google.com/p/go.blog #

Patch Set 7 : diff -r c12d094bfc1a https://code.google.com/p/go.blog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A content/gophercon.article View 1 2 3 4 5 1 chunk +51 lines, -0 lines 0 comments Download
A content/gophercon/image00.jpg View Binary file 0 comments Download
A content/gophercon/image01.jpg View Binary file 0 comments Download
A content/gophercon/image02.jpg View Binary file 0 comments Download

Messages

Total messages: 9
adg
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.blog
9 years, 11 months ago (2014-05-28 06:08:20 UTC) #1
r
LGTM but i'd prefer it if you broke the lines at least on sentence boundaries. ...
9 years, 11 months ago (2014-05-28 06:10:15 UTC) #2
adg
Hello r@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 11 months ago (2014-05-28 06:13:24 UTC) #3
adg
Actually hold on, the URLs are all messed up.
9 years, 11 months ago (2014-05-28 06:14:44 UTC) #4
dave_cheney.net
https://codereview.appspot.com/92630044/diff/20001/content/gophercon.article File content/gophercon.article (right): https://codereview.appspot.com/92630044/diff/20001/content/gophercon.article#newcode40 content/gophercon.article:40: The gopher was also also seen wearing a cape ...
9 years, 11 months ago (2014-05-28 06:15:38 UTC) #5
adg
PTAL https://codereview.appspot.com/92630044/diff/20001/content/gophercon.article File content/gophercon.article (right): https://codereview.appspot.com/92630044/diff/20001/content/gophercon.article#newcode40 content/gophercon.article:40: The gopher was also also seen wearing a ...
9 years, 11 months ago (2014-05-28 06:19:07 UTC) #6
dave_cheney.net
LGTM. Ta
9 years, 11 months ago (2014-05-28 06:25:36 UTC) #7
r
LGTM
9 years, 11 months ago (2014-05-28 20:06:02 UTC) #8
adg
9 years, 11 months ago (2014-05-28 22:40:37 UTC) #9
*** Submitted as
https://code.google.com/p/go/source/detail?r=75154d06df67&repo=blog ***

go.blog: add "GopherCon 2014 Wrap Up"

LGTM=r, dave
R=r, dave
CC=golang-codereviews
https://codereview.appspot.com/92630044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b