Issue 92520045: code review 92520045: go-tour: Make syntax toggle work.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 92520045: code review 92520045: go-tour: Make syntax toggle work. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by francesc

Modified:
10 years ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

go-tour: Make syntax toggle work. fixes issue 175

Patch Set 2 : diff -r c0237d6f6a0e https://code.google.com/p/go-tour #

Patch Set 3 : diff -r c0237d6f6a0e https://code.google.com/p/go-tour #

Total comments: 2

Patch Set 4 : diff -r c0237d6f6a0e https://code.google.com/p/go-tour #

Patch Set 5 : diff -r c0237d6f6a0e https://code.google.com/p/go-tour #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -11 lines)			Patch
M	static/css/app.css	View	1 2	1 chunk	+7 lines, -4 lines	0 comments	Download
M	static/js/controllers.js	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	static/js/services.js	View	1 2 3	1 chunk	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

francesc

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

10 years ago (2014-05-21 03:22:44 UTC) #1

adg

https://codereview.appspot.com/92520045/diff/40001/static/js/services.js File static/js/services.js (right): https://codereview.appspot.com/92520045/diff/40001/static/js/services.js#newcode68 static/js/services.js:68: window.setTimeout(set, 10); why call this 100 times a second?

10 years ago (2014-05-21 03:35:30 UTC) #2

francesc

PTAL https://codereview.appspot.com/92520045/diff/40001/static/js/services.js File static/js/services.js (right): https://codereview.appspot.com/92520045/diff/40001/static/js/services.js#newcode68 static/js/services.js:68: window.setTimeout(set, 10); On 2014/05/21 03:35:30, adg wrote: > ...

10 years ago (2014-05-21 03:50:27 UTC) #3

francesc

10 years ago (2014-05-21 04:11:19 UTC) #5

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=27fad7d05796
***

go-tour: Make syntax toggle work.

fixes issue 175

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/92520045

Expand All Messages | Collapse All Messages