Issue 9244043: code review 9244043: doc: add FAQ entry about language changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9244043: code review 9244043: doc: add FAQ entry about language changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by adg

Modified:
10 years, 11 months ago

Reviewers:

CC:
golang-dev, dsymonds, r

Visibility:
Public.

Description

doc: add FAQ entry about language changes

Patch Set 2 : diff -r 17c26220ac96 https://code.google.com/p/go #

Patch Set 3 : diff -r 17c26220ac96 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 34b8901146ac https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	doc/go_faq.html	View	1 2 3	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2013-05-06 21:39:48 UTC) #1

dsymonds

Maybe phrase the question as a less negative "Will you accept my language change?"?

10 years, 11 months ago (2013-05-06 21:41:56 UTC) #2

adg

On 6 May 2013 14:41, David Symonds <dsymonds@golang.org> wrote: > Will you accept my language ...

10 years, 11 months ago (2013-05-06 21:44:07 UTC) #3

LGTM https://codereview.appspot.com/9244043/diff/6001/doc/go_faq.html File doc/go_faq.html (right): https://codereview.appspot.com/9244043/diff/6001/doc/go_faq.html#newcode461 doc/go_faq.html:461: People often suggest improvements to the language–the this ...

10 years, 11 months ago (2013-05-06 22:00:42 UTC) #4

adg

10 years, 11 months ago (2013-05-06 22:03:00 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=0d411dd887b7 ***

doc: add FAQ entry about language changes

R=golang-dev, dsymonds, r
CC=golang-dev
https://codereview.appspot.com/9244043

Expand All Messages | Collapse All Messages