Should I create a new CL ? On Sun, May 11, 2014 at 10:46 PM, ...
9 years, 9 months ago
(2014-06-12 16:40:55 UTC)
#3
Should I create a new CL ?
On Sun, May 11, 2014 at 10:46 PM, <iant@golang.org> wrote:
> R=close
>
> Please ping this CL after the 1.3 release is out. Thanks.
>
>
> https://codereview.appspot.com/92230043/
--
LinkedIn: http://linkedin.com/in/fmilo
Twitter: @fabmilo
Github: http://github.com/Mistobaan/
-----------------------
Simplicity, consistency, and repetition - that's how you get through.
(Jack Welch)
Perfection must be reached by degrees; she requires the slow hand of
time (Voltaire)
The best way to predict the future is to invent it (Alan Kay)
Testing EncodeElement is a good idea, but this doesn't seem like a great test. The ...
9 years, 9 months ago
(2014-07-03 01:07:56 UTC)
#4
Testing EncodeElement is a good idea, but this doesn't seem like a great test.
The test should not test merely that something was written, it should test that
the right data was written.
Updated with this one https://codereview.appspot.com/110850044 On Thu, Jun 12, 2014 at 9:40 AM, Fabrizio Milo ...
9 years, 8 months ago
(2014-07-07 05:51:54 UTC)
#5
Updated with this one https://codereview.appspot.com/110850044
On Thu, Jun 12, 2014 at 9:40 AM, Fabrizio Milo aka misto
<mistobaan@gmail.com> wrote:
> Should I create a new CL ?
>
> On Sun, May 11, 2014 at 10:46 PM, <iant@golang.org> wrote:
>> R=close
>>
>> Please ping this CL after the 1.3 release is out. Thanks.
>>
>>
>> https://codereview.appspot.com/92230043/
>
>
>
> --
> LinkedIn: http://linkedin.com/in/fmilo
> Twitter: @fabmilo
> Github: http://github.com/Mistobaan/
> -----------------------
> Simplicity, consistency, and repetition - that's how you get through.
> (Jack Welch)
> Perfection must be reached by degrees; she requires the slow hand of
> time (Voltaire)
> The best way to predict the future is to invent it (Alan Kay)
--
LinkedIn: http://linkedin.com/in/fmilo
Twitter: @fabmilo
Github: http://github.com/Mistobaan/
-----------------------
Simplicity, consistency, and repetition - that's how you get through.
(Jack Welch)
Perfection must be reached by degrees; she requires the slow hand of
time (Voltaire)
The best way to predict the future is to invent it (Alan Kay)
Issue 92230043: code review 92230043: encoding/xml: add test for EncodeElement
Created 9 years, 10 months ago by fabmilo
Modified 9 years, 8 months ago
Reviewers: golang-codereviews, iant
Base URL:
Comments: 0