Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(159)

Issue 92230043: code review 92230043: encoding/xml: add test for EncodeElement

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by fabmilo
Modified:
9 years, 8 months ago
Visibility:
Public.

Description

encoding/xml: add test for EncodeElement Update issue 6094

Patch Set 1 #

Patch Set 2 : diff -r 87c97fd0aee6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 87c97fd0aee6 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 299229ac4300 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 299229ac4300 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 299229ac4300 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/pkg/encoding/xml/marshal_test.go View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5
fabmilo
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 10 months ago (2014-05-11 02:34:13 UTC) #1
iant
R=close Please ping this CL after the 1.3 release is out. Thanks.
9 years, 10 months ago (2014-05-12 05:46:15 UTC) #2
fabmilo
Should I create a new CL ? On Sun, May 11, 2014 at 10:46 PM, ...
9 years, 9 months ago (2014-06-12 16:40:55 UTC) #3
iant
Testing EncodeElement is a good idea, but this doesn't seem like a great test. The ...
9 years, 9 months ago (2014-07-03 01:07:56 UTC) #4
fabmilo
9 years, 8 months ago (2014-07-07 05:51:54 UTC) #5
Updated with this one https://codereview.appspot.com/110850044

On Thu, Jun 12, 2014 at 9:40 AM, Fabrizio Milo aka misto
<mistobaan@gmail.com> wrote:
> Should I create a new CL ?
>
> On Sun, May 11, 2014 at 10:46 PM,  <iant@golang.org> wrote:
>> R=close
>>
>> Please ping this CL after the 1.3 release is out.  Thanks.
>>
>>
>> https://codereview.appspot.com/92230043/
>
>
>
> --
> LinkedIn: http://linkedin.com/in/fmilo
> Twitter: @fabmilo
> Github: http://github.com/Mistobaan/
> -----------------------
> Simplicity, consistency, and repetition - that's how you get through.
> (Jack Welch)
> Perfection must be reached by degrees; she requires the slow hand of
> time (Voltaire)
> The best way to predict the future is to invent it (Alan Kay)



-- 
LinkedIn: http://linkedin.com/in/fmilo
Twitter: @fabmilo
Github: http://github.com/Mistobaan/
-----------------------
Simplicity, consistency, and repetition - that's how you get through.
(Jack Welch)
Perfection must be reached by degrees; she requires the slow hand of
time (Voltaire)
The best way to predict the future is to invent it (Alan Kay)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b