Issue 92210044: code review 92210044: net: make use of SO_LINGER_SEC on darwin

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 92210044: code review 92210044: net: make use of SO_LINGER_SEC on darwin (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by mikio

Modified:
9 years, 11 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

net: make use of SO_LINGER_SEC on darwin Fixes issue 7971.

Patch Set 1 : diff -r 0503d30ff99e https://code.google.com/p/go #

Patch Set 2 : diff -r cdacb45554e6 https://code.google.com/p/go #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pkg/net/sockopt_posix.go	View		2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 11 months ago (2014-05-12 03:16:32 UTC) #1

mikio

*** Submitted as https://code.google.com/p/go/source/detail?r=5cb21eee2d35 *** net: make use of SO_LINGER_SEC on darwin Fixes issue 7971. ...

9 years, 11 months ago (2014-05-12 15:38:44 UTC) #3

gobot

This CL appears to have broken the freebsd-amd64 builder. See http://build.golang.org/log/727cc9608496b0875a0d8f576ebb181f9dd95ffd

9 years, 11 months ago (2014-05-12 15:40:31 UTC) #4

mikio

sorry, on it. On Tue, May 13, 2014 at 12:40 AM, <gobot@golang.org> wrote: > This ...

9 years, 11 months ago (2014-05-12 15:42:21 UTC) #5

gobot

9 years, 11 months ago (2014-05-13 22:07:26 UTC) #6

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64 builder.
See http://build.golang.org/log/421b144da3dc411df5dddb9cf67d7fa9282f6f71

Expand All Messages | Collapse All Messages