Issue 91830045: code review 91830045: net/rpc: Add call to Close() to prevent file descriptor...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 91830045: code review 91830045: net/rpc: Add call to Close() to prevent file descriptor... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by scheiber

Modified:
10 years ago

Reviewers:
golang-codereviews, robryk

Visibility:
Public.

Description

net/rpc: Add call to Close() to prevent file descriptor leaks. Fixes issue 6897.

Patch Set 2 : diff -r aefa5032b453 https://code.google.com/p/go/ #

Patch Set 3 : diff -r eba73fe6f55e https://code.google.com/p/go/ #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/net/rpc/client.go	View	1	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

scheiber

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years ago (2014-04-27 04:59:07 UTC) #1

robryk

https://codereview.appspot.com/91830045/diff/40001/src/pkg/net/rpc/client.go File src/pkg/net/rpc/client.go (right): https://codereview.appspot.com/91830045/diff/40001/src/pkg/net/rpc/client.go#newcode279 src/pkg/net/rpc/client.go:279: client.codec.Close() Shouldn't we call Close() here only if client.closing ...

10 years ago (2014-04-27 15:38:57 UTC) #2

*** Abandoned ***

Expand All Messages | Collapse All Messages