Issue 91770048: code review 91770048: net/http/httputil: don't leak goroutines in DumpRequestOut

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 91770048: code review 91770048: net/http/httputil: don't leak goroutines in DumpRequestOut (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by bradfitz

Modified:
10 years ago

Reviewers:
dsymonds

CC:
golang-codereviews, adg, dsymonds, rsc

Visibility:
Public.

Description

net/http/httputil: don't leak goroutines in DumpRequestOut Fixes Issue 7869

Patch Set 1 #

Patch Set 2 : diff -r acf346c00e56 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r acf346c00e56 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 28fb7ad674f0 https://go.googlecode.com/hg/ #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/pkg/net/http/httputil/dump.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/net/http/httputil/dump_test.go	View	1 2 3	3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com (cc: adg@golang.org, dsymonds@golang.org, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

10 years ago (2014-04-25 22:11:12 UTC) #1

dsymonds

LGTM Test has a typo. Also you aren't expressing yourself enough.

10 years ago (2014-04-25 22:16:36 UTC) #2

bradfitz

10 years ago (2014-04-25 22:19:39 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=490c2d4fda2b ***

net/http/httputil: don't leak goroutines in DumpRequestOut

Fixes Issue 7869

LGTM=dsymonds
R=golang-codereviews
CC=adg, dsymonds, golang-codereviews, rsc
https://codereview.appspot.com/91770048

Expand All Messages | Collapse All Messages