Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(803)

Issue 9159043: code review 9159043: net: fix dial race on plan9 and windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by brainman
Modified:
10 years, 10 months ago
Reviewers:
CC:
golang-dev, lucio, dsymonds, bradfitz, iant, adg, dfc, r
Visibility:
Public.

Description

net: fix dial race on plan9 and windows Fixes issue 5349.

Patch Set 1 #

Patch Set 2 : diff -r 740d244b2047 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 740d244b2047 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 740d244b2047 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 740d244b2047 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r bbe324079abe https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r bbe324079abe https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M src/pkg/net/dial_gen.go View 1 2 chunks +15 lines, -3 lines 0 comments Download
A src/pkg/net/dial_gen_test.go View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 11 months ago (2013-05-03 05:49:04 UTC) #1
lucio
Won't please you make sure the description contains "plan 9" rather than just "plan"? Lucio. ...
10 years, 11 months ago (2013-05-03 09:51:13 UTC) #2
brainman
On 2013/05/03 09:51:13, lucio wrote: > Won't please you make sure the description contains "plan ...
10 years, 11 months ago (2013-05-03 12:53:57 UTC) #3
dsymonds
maybe fix the spelling of "dial" in the CL description too.
10 years, 10 months ago (2013-05-07 18:04:03 UTC) #4
bradfitz
LGTM
10 years, 10 months ago (2013-05-07 18:26:53 UTC) #5
iant
LGTM
10 years, 10 months ago (2013-05-07 20:17:59 UTC) #6
brainman
On 2013/05/07 18:04:03, dsymonds wrote: > maybe fix the spelling of "dial" in the CL ...
10 years, 10 months ago (2013-05-07 23:51:00 UTC) #7
bradfitz
Please reupload. Rietveld is confused: https://codereview.appspot.com/9159043/diff/17001/src/pkg/net/dial_gen.go I think adg & r want rc2 to be ...
10 years, 10 months ago (2013-05-08 00:00:30 UTC) #8
adg
On 7 May 2013 17:00, Brad Fitzpatrick <bradfitz@golang.org> wrote: > Nobody spoke up about this ...
10 years, 10 months ago (2013-05-08 00:02:01 UTC) #9
brainman
On 2013/05/08 00:00:30, bradfitz wrote: > Please reupload. Rietveld is confused: > https://codereview.appspot.com/9159043/diff/17001/src/pkg/net/dial_gen.go I just ...
10 years, 10 months ago (2013-05-08 00:10:51 UTC) #10
dfc
Yes, if you view the CL, the most current revision is broken because of a ...
10 years, 10 months ago (2013-05-08 00:13:57 UTC) #11
brainman
Hello golang-dev@googlegroups.com, lucio.dere@gmail.com, dsymonds@golang.org, bradfitz@golang.org, iant@golang.org, adg@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 10 months ago (2013-05-08 00:25:21 UTC) #12
brainman
On 2013/05/08 00:13:57, dfc wrote: > Yes, if you view the CL, the most current ...
10 years, 10 months ago (2013-05-08 00:25:49 UTC) #13
r
LGTM
10 years, 10 months ago (2013-05-08 06:06:49 UTC) #14
brainman
10 years, 10 months ago (2013-05-08 06:19:11 UTC) #15
*** Submitted as https://code.google.com/p/go/source/detail?r=f1ddc3ce3dfe ***

net: fix dial race on plan9 and windows

Fixes issue 5349.

R=golang-dev, lucio.dere, dsymonds, bradfitz, iant, adg, dave, r
CC=golang-dev
https://codereview.appspot.com/9159043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b