code review 91540043: cmd/gc: fix <-<-expr

cmd/gc: fix <-<-expr

The temporary-introducing pass was not recursing
into the argumnt of a receive operation.

Fixes issue 8011.

[rsc, 2014-05-19 18:52:27]

Hello golang-codereviews@googlegroups.com (cc: iant, khr, r),

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2014-05-19 18:59:07]

LGTM

[rsc, 2014-05-19 19:08:05]

*** Submitted as https://code.google.com/p/go/source/detail?r=d419520d0d2e ***

cmd/gc: fix <-<-expr

The temporary-introducing pass was not recursing
into the argumnt of a receive operation.

Fixes issue 8011.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant, khr
https://codereview.appspot.com/91540043

[gobot, 2014-05-19 19:20:10]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/fb06405fad3ba83903fdff073454ba091770ab8a

[bradfitz, 2014-05-19 19:22:27]

Looks possibly real:

TestSelect:

select {
0: blocking send canselect
1: nil Chan send
} blocked indefinitely
panic: select stuck

goroutine 53 [running]:
runtime.panic(0x55a380, 0xc208001560)
/usr/local/go/src/pkg/runtime/panic.c:279 +0xf5
reflect_test.selectWatcher()
/tmp/gobuilder/netbsd-amd64-bsiegert-d419520d0d2e/go/src/pkg/reflect/all_test.go:1378
+0x1c5
created by reflect_test.func·003
/tmp/gobuilder/netbsd-amd64-bsiegert-d419520d0d2e/go/src/pkg/reflect/all_test.go:1104
+0x22

goroutine 16 [chan receive]:
testing.RunTests(0x652128, 0x6f4d80, 0x5a, 0x5a, 0x1)
/usr/local/go/src/pkg/testing/testing.go:505 +0x8be
testing.Main(0x652128, 0x6f4d80, 0x5a, 0x5a, 0x6eeda0, 0x5, 0x5, 0x6ee800,
0x2, 0x2)
/usr/local/go/src/pkg/testing/testing.go:435 +0x84
main.main()
reflect/_test/_testmain.go:239 +0x9c

goroutine 19 [finalizer wait]:
runtime.park(0x413350, 0x6f6120, 0x6f4c49)
/usr/local/go/src/pkg/runtime/proc.c:1369 +0x89
runtime.parkunlock(0x6f6120, 0x6f4c49)
/usr/local/go/src/pkg/runtime/proc.c:1385 +0x3b
runfinq()
/usr/local/go/src/pkg/runtime/mgc0.c:2640 +0xcf
runtime.goexit()
/usr/local/go/src/pkg/runtime/proc.c:1445

goroutine 52 [runnable]:
reflect.rselect(0xc2080527c0, 0x2, 0x2, 0xffffffffffffffff, 0x5d7000)
/usr/local/go/src/pkg/runtime/chan.goc:1020 +0xa5
reflect.Select(0xc2080c18c0, 0x2, 0x2, 0xc208052588, 0x0, 0x0, 0x0, 0x0,
0xc208001510)
/tmp/gobuilder/netbsd-amd64-bsiegert-d419520d0d2e/go/src/pkg/reflect/value.go:2186
+0x1fb
reflect_test.runSelect(0xc2080c18c0, 0x2, 0x2, 0xc208092320, 0x2, 0x2, 0x0,
0x0, 0x0, 0x0, ...)
/tmp/gobuilder/netbsd-amd64-bsiegert-d419520d0d2e/go/src/pkg/reflect/all_test.go:1401
+0x1b0
reflect_test.TestSelect(0xc208010cf0)
/tmp/gobuilder/netbsd-amd64-bsiegert-d419520d0d2e/go/src/pkg/reflect/all_test.go:1316
+0x2121
testing.tRunner(0xc208010cf0, 0x6f5068)
/usr/local/go/src/pkg/testing/testing.go:422 +0x8b
created by testing.RunTests
/usr/local/go/src/pkg/testing/testing.go:504 +0x876
FAIL reflect 1.279s





On Mon, May 19, 2014 at 12:20 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/fb06405fad3ba83903fdff073454ba091770ab8a
>
>
> https://codereview.appspot.com/91540043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-05-19 19:32:30]

Until I see this on a builder I trust, I'm going to assume this is just the
NetBSD builder randomly breaking, and it happened to break in a way that
looks relevant to the CL being checked. Even a broken clock is right twice
a day.

Russ

[r, 2014-05-19 20:00:29]

I don't believe this is real.

On Mon, May 19, 2014 at 12:32 PM, Russ Cox <rsc@golang.org> wrote:
> Until I see this on a builder I trust, I'm going to assume this is just the
> NetBSD builder randomly breaking, and it happened to break in a way that
> looks relevant to the CL being checked. Even a broken clock is right twice a
> day.
>
> Russ