https://codereview.appspot.com/91520043/diff/80001/doc/go1.3.html File doc/go1.3.html (right): https://codereview.appspot.com/91520043/diff/80001/doc/go1.3.html#newcode246 doc/go1.3.html:246: corresponding C types are different. Before Go 1.3, cgo ...
9 years, 11 months ago
(2014-05-19 16:47:05 UTC)
#3
leaving for rsc https://codereview.appspot.com/91520043/diff/120001/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): https://codereview.appspot.com/91520043/diff/120001/src/cmd/cgo/doc.go#newcode108 src/cmd/cgo/doc.go:108: Opaque types in C (such as ...
9 years, 11 months ago
(2014-05-20 18:59:55 UTC)
#5
PTAL. https://codereview.appspot.com/91520043/diff/120001/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): https://codereview.appspot.com/91520043/diff/120001/src/cmd/cgo/doc.go#newcode108 src/cmd/cgo/doc.go:108: Opaque types in C (such as void* or ...
9 years, 11 months ago
(2014-05-20 19:08:58 UTC)
#6
LGTM https://codereview.appspot.com/91520043/diff/160001/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): https://codereview.appspot.com/91520043/diff/160001/src/cmd/cgo/doc.go#newcode110 src/cmd/cgo/doc.go:110: Cgo translates C types into their equivalent Go ...
9 years, 10 months ago
(2014-05-30 21:08:15 UTC)
#9
On Sat, May 31, 2014 at 1:01 AM, <gobot@golang.org> wrote: > This CL appears to ...
9 years, 10 months ago
(2014-05-31 08:13:04 UTC)
#12
On Sat, May 31, 2014 at 1:01 AM, <gobot@golang.org> wrote:
> This CL appears to have broken the plan9-386-cnielsen builder.
> See http://build.golang.org/log/327e716d60c0f250b9a103832a961348cf2e27c2
--- FAIL: TestResponseWriterWriteStringAllocs (0.00 seconds)
serve_test.go:2292: WriteString allocs of 21 >= Write allocs of 21
FAIL
FAIL net/http 19.196s
it seems testing.AllocPerRun tests are still flaky.
Issue 91520043: code review 91520043: cmd/cgo: document the cgo types also follow Go name spa...
(Closed)
Created 9 years, 11 months ago by minux1
Modified 9 years, 10 months ago
Reviewers: gobot, minux
Base URL:
Comments: 7