Issue 91500044: code review 91500044: cmd/addr2line, cmd/objdump: handle Plan 9 a.out object files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 91500044: code review 91500044: cmd/addr2line, cmd/objdump: handle Plan 9 a.out object files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by 0intro

Modified:
9 years, 12 months ago

Reviewers:
iant

CC:
rsc, iant, golang-codereviews

Visibility:
Public.

Description

cmd/addr2line, cmd/objdump: handle Plan 9 a.out object files Update issue 7947.

Patch Set 1 #

Patch Set 2 : diff -r 27c3e2da6b34 https://code.google.com/p/go #

Patch Set 3 : diff -r e2509b1f3a91 https://code.google.com/p/go #

Patch Set 4 : diff -r e2509b1f3a91 https://code.google.com/p/go #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -6 lines)			Patch
M	src/cmd/addr2line/addr2line_test.go	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/cmd/addr2line/main.go	View	1 2	3 chunks	+54 lines, -0 lines	0 comments	Download
M	src/cmd/objdump/main.go	View	1 2	3 chunks	+57 lines, -0 lines	0 comments	Download
M	src/cmd/objdump/objdump_test.go	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

0intro

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years ago (2014-05-15 15:18:00 UTC) #1

0intro

Alternatively, I propose to use the e?pclntab and e?symtab symbols to locate the sections. It's ...

9 years, 12 months ago (2014-05-16 09:31:47 UTC) #3

0intro

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

9 years, 12 months ago (2014-05-16 09:33:33 UTC) #4

iant

LGTM I don't really have an opinion as to which approach to use. This one ...

9 years, 12 months ago (2014-05-16 13:29:17 UTC) #5

0intro

9 years, 12 months ago (2014-05-16 14:52:21 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=b3ce999deddb ***

cmd/addr2line, cmd/objdump: handle Plan 9 a.out object files

Update issue 7947.

LGTM=iant
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/91500044

Expand All Messages | Collapse All Messages