Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1048)

Issue 9137045: code review 9137045: [release-branch.go1.1] effective_go.html: be more accep... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by adg
Modified:
10 years, 10 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

[release-branch.go1.1] effective_go.html: be more accepting in the guidelines for interface names ««« CL 9274043 / bbe324079abe effective_go.html: be more accepting in the guidelines for interface names Fixes issue 5421. R=golang-dev, bradfitz, adg CC=golang-dev https://codereview.appspot.com/9274043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 35da6063e57f https://code.google.com/p/go #

Patch Set 3 : diff -r 35da6063e57f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M doc/effective_go.html View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 10 months ago (2013-05-08 22:57:04 UTC) #1
r
LGTM
10 years, 10 months ago (2013-05-08 22:57:35 UTC) #2
adg
10 years, 10 months ago (2013-05-08 22:57:49 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=9e1dac980adb ***

[release-branch.go1.1] effective_go.html: be more accepting in the guidelines
for interface names

««« CL 9274043 / bbe324079abe
effective_go.html: be more accepting in the guidelines for interface names
Fixes issue 5421.

R=golang-dev, bradfitz, adg
CC=golang-dev
https://codereview.appspot.com/9274043
»»»

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/9137045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b