database/sql: Add `RegisteredDrivers() []string` API; i...

database/sql: Add `RegisteredDrivers() []string` API; issue 7969
See discussion here: https://groups.google.com/forum/#!topic/golang-nuts/6nBDvrOJBAw

[weberc2, 2014-05-11 16:19:52]

https://codereview.appspot.com/91350043/diff/20001/src/pkg/database/sql/sql.go
File src/pkg/database/sql/sql.go (right):

https://codereview.appspot.com/91350043/diff/20001/src/pkg/database/sql/sql.g...
src/pkg/database/sql/sql.go:41: func RegisteredDrivers() []string {
Is this signature good? Should it return map[string]driver.Driver? Or should the
function name specifically indicate that it's just returning the driver names?
Please advise.

[bradfitz, 2014-09-29 18:47:32]

LGTM but please make changes below first.

https://codereview.appspot.com/91350043/diff/20001/src/pkg/database/sql/sql.go
File src/pkg/database/sql/sql.go (right):

https://codereview.appspot.com/91350043/diff/20001/src/pkg/database/sql/sql.g...
src/pkg/database/sql/sql.go:40: // RegisteredDrivers returns a list of names of
registered drivers
add a period at the end of the sentence.

You can drop "list" too. That's obvious from the signature.

// RegisteredDrivers returns the names of registered drivers.

https://codereview.appspot.com/91350043/diff/20001/src/pkg/database/sql/sql.g...
src/pkg/database/sql/sql.go:41: func RegisteredDrivers() []string {
On 2014/05/11 16:19:52, weberc2 wrote:
> Is this signature good? Should it return map[string]driver.Driver? Or should
the
> function name specifically indicate that it's just returning the driver names?
> Please advise.

This signature is fine.

https://codereview.appspot.com/91350043/diff/20001/src/pkg/database/sql/sql.g...
src/pkg/database/sql/sql.go:42: names := make([]string, len(drivers))
if you do make([]string, 0, len(drivers)) here, you can just do append below and
drop the i variable.

  names = append(names, name)

https://codereview.appspot.com/91350043/diff/20001/src/pkg/database/sql/sql.g...
src/pkg/database/sql/sql.go:44: for name, _ := range drivers {
drop the ", _"

[rsc, 2014-10-15 03:07:38]

Timed out.
https://codereview.appspot.com/158950043 instead.