code review 9108043: database/sql: remove an unused field from Rows

database/sql: remove an unused field from Rows

Found while debugging memory usage. Nobody accesses this field
anymore.

[bradfitz, 2013-05-01 22:36:38]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[nitrix, 2013-05-02 02:50:15]

Seems like we use from driverConn.db instead. LGTM.

[bradfitz, 2013-05-03 02:12:24]

R=r

Go 1.1? This isn't critical, but it's also safe and saves memory and
complexity.  Either way.

I'll have larger changes coming after we fork off 1.1 anyway, so can do
this then.




On Wed, May 1, 2013 at 3:36 PM, <bradfitz@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> database/sql: remove an unused field from Rows
>
> Found while debugging memory usage. Nobody accesses this field
> anymore.
>
> Please review this at
https://codereview.appspot.**com/9108043/<https://codereview.appspot.com/9108...
>
> Affected files:
>   M src/pkg/database/sql/sql.go
>
>
> Index: src/pkg/database/sql/sql.go
> ==============================**==============================**=======
> --- a/src/pkg/database/sql/sql.go
> +++ b/src/pkg/database/sql/sql.go
> @@ -735,7 +735,6 @@
>                         // Note: ownership of dc passes to the *Rows, to
> be freed
>                         // with releaseConn.
>                         rows := &Rows{
> -                               db:          db,
>                                 dc:          dc,
>                                 releaseConn: releaseConn,
>                                 rowsi:       rowsi,
> @@ -765,7 +764,6 @@
>         // Note: ownership of ci passes to the *Rows, to be freed
>         // with releaseConn.
>         rows := &Rows{
> -               db:          db,
>                 dc:          dc,
>                 releaseConn: releaseConn,
>                 rowsi:       rowsi,
> @@ -1181,7 +1179,6 @@
>         // Note: ownership of ci passes to the *Rows, to be freed
>         // with releaseConn.
>         rows := &Rows{
> -               db:    s.db,
>                 dc:    dc,
>                 rowsi: rowsi,
>                 // releaseConn set below
> @@ -1286,7 +1283,6 @@
>  //     err = rows.Err() // get any error encountered during iteration
>  //     ...
>  type Rows struct {
> -       db          *DB
>         dc          *driverConn // owned; must call releaseConn when
> closed to release
>         releaseConn func(error)
>         rowsi       driver.Rows
>
>
>

[adg, 2013-05-03 13:53:31]

LGTM

[r, 2013-05-06 21:11:01]

LGTM

[bradfitz, 2013-05-06 22:16:50]

*** Submitted as https://code.google.com/p/go/source/detail?r=a1990e26c7fb ***

database/sql: remove an unused field from Rows

Found while debugging memory usage. Nobody accesses this field
anymore.

R=golang-dev, i.caught.air, adg, r
CC=golang-dev
https://codereview.appspot.com/9108043