Issue 90820043: code review 90820043: encoding/ascii85: handle non-data bytes correctly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 90820043: code review 90820043: encoding/ascii85: handle non-data bytes correctly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by ruiu

Modified:
10 years ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

encoding/ascii85: handle non-data bytes correctly Previously Read wouldn't return once its internal input buffer is filled with non-data bytes. Fixes issue 7875.

Patch Set 1 #

Patch Set 2 : diff -r e141dda580af https://code.google.com/p/go #

Patch Set 3 : diff -r e141dda580af https://code.google.com/p/go #

Patch Set 4 : diff -r e141dda580af https://code.google.com/p/go #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	src/pkg/encoding/ascii85/ascii85.go	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
	M	src/pkg/encoding/ascii85/ascii85_test.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ruiu

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years ago (2014-04-26 23:49:43 UTC) #1

iant

10 years ago (2014-04-27 02:56:08 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6ac6282568e3 ***

encoding/ascii85: handle non-data bytes correctly

Previously Read wouldn't return once its internal input buffer
is filled with non-data bytes.
Fixes issue 7875.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/90820043

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages