code review 90790044: go.net/proxy: Don't pass invalid hostname length to SOC...

go.net/proxy: Don't pass invalid hostname length to SOCKS5 proxies

SOCKS5 uses a single-byte field for hostname length. This change
causes dials to hostnames longer than 255 chars to fail instead
of sending an invalid request to the proxy.

[robryk, 2014-04-26 12:23:17]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.net

[mikio, 2014-04-26 15:11:29]

lgtm

will submit with a tweak to the cl description; s/hostname/domainname/

[mikio, 2014-04-26 15:24:44]

*** Submitted as
https://code.google.com/p/go/source/detail?r=b6d56582945d&repo=net ***

go.net/proxy: don't pass invalid domain name length to SOCKS5 proxies

SOCKS5 uses a single-byte field for domain name length. This change
causes dials to domain names longer than 255 chars to fail instead
of sending an invalid request to the proxy.

LGTM=mikioh.mikioh
R=golang-codereviews, mikioh.mikioh
CC=golang-codereviews
https://codereview.appspot.com/90790044

Committer: Mikio Hara <mikioh.mikioh@gmail.com>