code review 90170046: net: make WriteMsg{IP,UDP,Unix} return the correct numb...

net: make WriteMsg{IP,UDP,Unix} return the correct number of bytes transferred

Fixes issue 7645

[iant, 2014-04-25 14:27:14]

LGTM

[mikio, 2014-04-25 21:38:21]

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-04-25 21:39:47]

LGTM
 On Apr 25, 2014 3:38 PM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: iant,
>
> Message:
> Hello iant@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: make WriteMsg{IP,UDP,Unix} return the correct number of bytes
> transferred
>
> Fixes issue 7645
>
> Please review this at https://codereview.appspot.com/90170046/
>
> Affected files (+1, -2 lines):
>   M src/pkg/net/fd_unix.go
>
>
> Index: src/pkg/net/fd_unix.go
> ===================================================================
> --- a/src/pkg/net/fd_unix.go
> +++ b/src/pkg/net/fd_unix.go
> @@ -375,7 +375,7 @@
>                 return 0, 0, &OpError{"write", fd.net, fd.raddr, err}
>         }
>         for {
> -               err = syscall.Sendmsg(fd.sysfd, p, oob, sa, 0)
> +               n, err = syscall.SendmsgN(fd.sysfd, p, oob, sa, 0)
>                 if err == syscall.EAGAIN {
>                         if err = fd.pd.WaitWrite(); err == nil {
>                                 continue
> @@ -384,7 +384,6 @@
>                 break
>         }
>         if err == nil {
> -               n = len(p)
>                 oobn = len(oob)
>         } else {
>                 err = &OpError{"write", fd.net, fd.raddr, err}
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[mikio, 2014-04-25 21:52:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=28fb7ad674f0 ***

net: make WriteMsg{IP,UDP,Unix} return the correct number of bytes transferred

Fixes issue 7645

LGTM=iant, bradfitz
R=iant, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/90170046