Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(453)

Issue 8934043: code review 8934043: net: deflake raw IP protocol entry test on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by mikio
Modified:
10 years, 11 months ago
Reviewers:
CC:
golang-dev, dfc, r, brainman
Visibility:
Public.

Description

net: deflake raw IP protocol entry test on Windows Update issue 5344

Patch Set 1 #

Patch Set 2 : diff -r e729bb70416a https://code.google.com/p/go #

Patch Set 3 : diff -r e729bb70416a https://code.google.com/p/go #

Patch Set 4 : diff -r d4c3e6c8b141 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/pkg/net/ipraw_test.go View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 11 months ago (2013-04-24 11:12:17 UTC) #1
dfc
LGTM. Thank you. Please wait for brainman to confirm, and r for permission to submit.
10 years, 11 months ago (2013-04-24 11:38:07 UTC) #2
r
LGTM
10 years, 11 months ago (2013-04-24 16:15:41 UTC) #3
brainman
LGTM
10 years, 11 months ago (2013-04-25 00:59:20 UTC) #4
mikio
10 years, 11 months ago (2013-04-25 04:23:34 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=0c16e97c7587 ***

net: deflake raw IP protocol entry test on Windows

Update issue 5344

R=golang-dev, dave, r, alex.brainman
CC=golang-dev
https://codereview.appspot.com/8934043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b