Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 89300044: code review 89300044: ogle/debug/dwarf: use existing I/O implementation to pa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by r
Modified:
9 years, 11 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle/debug/dwarf: use existing I/O implementation to parse line table

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 2747377222b1 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -135 lines) Patch
M debug/dwarf/line.go View 1 6 chunks +68 lines, -135 lines 0 comments Download

Messages

Total messages: 3
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
9 years, 11 months ago (2014-04-18 19:56:12 UTC) #1
nigeltao
LGTM. https://codereview.appspot.com/89300044/diff/1/debug/dwarf/line.go File debug/dwarf/line.go (right): https://codereview.appspot.com/89300044/diff/1/debug/dwarf/line.go#newcode249 debug/dwarf/line.go:249: // evalCompilationUnit reads the mext compilation unit to ...
9 years, 11 months ago (2014-04-18 23:33:11 UTC) #2
r
9 years, 11 months ago (2014-04-18 23:38:49 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=fe71428bbae6 ***

ogle/debug/dwarf: use existing I/O implementation to parse line table

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/89300044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b