Issue 89230044: code review 89230044: cmd/go: handle -ccflags in 'go test'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 89230044: code review 89230044: cmd/go: handle -ccflags in 'go test' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by minux1

Modified:
10 years ago

Reviewers:
iant, Dobrosław Żybort

CC:
golang-codereviews, iant, Dobrosław Żybort

Visibility:
Public.

Description

cmd/go: handle -ccflags in 'go test' CL 89050043 only allows -ccflags for 'go test', this CL really handles the flag like the other -??flags. Many thanks to Dobrosław Żybort for pointing this out. Fixes issue 7810 (again).

Patch Set 1 #

Patch Set 2 : diff -r 510063e3f0b7 https://code.google.com/p/go #

Patch Set 3 : diff -r 510063e3f0b7 https://code.google.com/p/go #

Patch Set 4 : diff -r 1b5a82d4b552 https://code.google.com/p/go #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/cmd/go/testflag.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 1 month ago (2014-04-18 14:53:28 UTC) #1

minux1

10 years ago (2014-04-21 04:02:26 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=8279f39bcaf0 ***

cmd/go: handle -ccflags in 'go test'
CL 89050043 only allows -ccflags for 'go test', this
CL really handles the flag like the other -??flags.
Many thanks to Dobrosław Żybort for pointing this out.
Fixes issue 7810 (again).

LGTM=iant, matrixik
R=golang-codereviews, iant, matrixik
CC=golang-codereviews
https://codereview.appspot.com/89230044

Expand All Messages | Collapse All Messages