Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(817)

Issue 89190043: code review 89190043: ogle/program/server: stop Frames going past the top of ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by nigeltao
Modified:
9 years, 11 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/program/server: stop Frames going past the top of the stack.

Patch Set 1 #

Patch Set 2 : diff -r 3ade69b38442 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 3ade69b38442 https://code.google.com/p/ogle #

Total comments: 2

Patch Set 4 : diff -r 3ade69b38442 https://code.google.com/p/ogle #

Total comments: 3

Patch Set 5 : diff -r 3ade69b38442 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -10 lines) Patch
M program/server/dwarf.go View 1 3 chunks +6 lines, -5 lines 0 comments Download
M program/server/ptrace.go View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M program/server/server.go View 1 2 3 4 7 chunks +70 lines, -3 lines 0 comments Download

Messages

Total messages: 6
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
9 years, 11 months ago (2014-04-17 23:44:49 UTC) #1
r
https://codereview.appspot.com/89190043/diff/40001/program/server/server.go File program/server/server.go (right): https://codereview.appspot.com/89190043/diff/40001/program/server/server.go#newcode54 program/server/server.go:54: runtimeAddrGoexit uint64 i'd make this a separate struct so ...
9 years, 11 months ago (2014-04-18 00:09:32 UTC) #2
nigeltao
PTAL.
9 years, 11 months ago (2014-04-18 02:25:51 UTC) #3
r
LGTM i'd like the suggested renaming but it's up to you https://codereview.appspot.com/89190043/diff/60001/program/server/server.go File program/server/server.go (right): ...
9 years, 11 months ago (2014-04-18 03:36:02 UTC) #4
nigeltao
https://codereview.appspot.com/89190043/diff/60001/program/server/server.go File program/server/server.go (right): https://codereview.appspot.com/89190043/diff/60001/program/server/server.go#newcode61 program/server/server.go:61: goexit uint64 On 2014/04/18 03:36:02, r wrote: > why ...
9 years, 11 months ago (2014-04-18 14:08:57 UTC) #5
nigeltao
9 years, 11 months ago (2014-04-18 14:15:25 UTC) #6
*** Submitted as https://code.google.com/p/ogle/source/detail?r=26b078264221 ***

ogle/program/server: stop Frames going past the top of the stack.

LGTM=r
R=r
https://codereview.appspot.com/89190043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b