code review 89050043: cmd/go: support -ccflags in 'go test'

cmd/go: support -ccflags in 'go test'
Fixes issue 7810.

[minux1, 2014-04-17 20:57:10]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-04-17 21:05:35]

LGTM

[minux1, 2014-04-18 03:16:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=98d3b20ae792 ***

cmd/go: support -ccflags in 'go test'
Fixes issue 7810.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/89050043

[Dobrosław Żybort, 2014-04-18 09:47:03]

Shouldn't there be also:

> 
hg diff                                                                         
                          
diff -r 510063e3f0b7 src/cmd/go/testflag.go                                     
                                                                         
--- a/src/cmd/go/testflag.go    Fri Apr 18 10:50:06 2014 +0200                  
                                                                         
+++ b/src/cmd/go/testflag.go    Fri Apr 18 09:44:27 2014 +0000                  
                                                                         
@@ -160,6 +160,11 @@                                                            
                                                                         
                        if err != nil {                                         
                                                                         
                                fatalf("invalid flag argument for -%s: %v",
f.name, err)                                                                  
                        }                                                       
                                                                         
+               case "ccflags":                                                 
                                                                         
+                       buildCcflags, err = splitQuotedFields(value)            
                                                                         
+                       if err != nil {                                         
                                                                         
+                               fatalf("invalid flag argument for -%s: %v",
f.name, err)                                                                  
+                       }                                                       
                                                                         
                case "gcflags":                                                 
                                                                         
                        buildGcflags, err = splitQuotedFields(value)            
                                                                         
                        if err != nil {                                         
                                                                      


?

W dniu piątek, 18 kwietnia 2014 05:16:12 UTC+2 użytkownik minux napisał:
>
> *** Submitted as 
> https://code.google.com/p/go/source/detail?r=98d3b20ae792 *** 
>
> cmd/go: support -ccflags in 'go test' 
> Fixes issue 7810. 
>
> LGTM=iant 
> R=golang-codereviews, iant 
> CC=golang-codereviews 
> https://codereview.appspot.com/89050043 
>
>
> https://codereview.appspot.com/89050043/ 
>

[minux1, 2014-04-18 14:47:16]

On Apr 18, 2014 5:47 AM, "Dobrosław Żybort" <matrixik@gmail.com> wrote:
> Shouldn't there be also:
> > hg diff
> diff -r 510063e3f0b7 src/cmd/go/testflag.go
oops. you're absolutely right. clearly my tests were not sufficient.

CL 89230044 will fix this.