code review 8896045: all: fix typos

all: fix typos

[minux1, 2013-04-23 20:22:36]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-04-23 20:31:55]

LGTM



On Tue, Apr 23, 2013 at 1:22 PM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> all: fix typos
>
> Please review this at
https://codereview.appspot.**com/8896045/<https://codereview.appspot.com/8896...
>
> Affected files:
>   M doc/articles/image_package.**html
>   M doc/codewalk/urlpoll.go
>   M doc/devel/weekly.html
>   M src/pkg/net/http/serve_test.go
>   M src/pkg/net/http/server.go
>   M src/pkg/runtime/chan.c
>   M src/pkg/runtime/os_darwin.c
>
>
> Index: doc/articles/image_package.**html
> ==============================**==============================**=======
> --- a/doc/articles/image_package.**html
> +++ b/doc/articles/image_package.**html
> @@ -130,7 +130,7 @@
>  A <code>Rectangle</code> is inclusive at the top-left and exclusive at the
>  bottom-right. For a <code>Point p</code> and a <code>Rectangle r</code>,
>  <code>p.In(r)</code> if and only if
> -<code>r.Min.X &lt;= p.X &amp;&amp; p.X &lt; r.Max.X</code>, and similarly
> for <code>Y</code>. This is analagous to how
> +<code>r.Min.X &lt;= p.X &amp;&amp; p.X &lt; r.Max.X</code>, and similarly
> for <code>Y</code>. This is analogous to how
>  a slice <code>s[i0:i1]</code> is inclusive at the low end and exclusive
> at the
>  high end. (Unlike arrays and slices, a <code>Rectangle</code> often has a
>  non-zero origin.)
> @@ -236,7 +236,7 @@
>  The slice-based <code>Image</code> implementations also provide a
>  <code>SubImage</code> method, which returns an <code>Image</code> backed
> by the
>  same array. Modifying the pixels of a sub-image will affect the pixels of
> the
> -original image, analagous to how modifying the contents of a sub-slice
> +original image, analogous to how modifying the contents of a sub-slice
>  <code>s[i0:i1]</code> will affect the contents of the original slice
>  <code>s</code>.
>  </p>
> Index: doc/codewalk/urlpoll.go
> ==============================**==============================**=======
> --- a/doc/codewalk/urlpoll.go
> +++ b/doc/codewalk/urlpoll.go
> @@ -76,7 +76,7 @@
>         return resp.Status
>  }
>
> -// Sleep sleeps for an appropriate interval (dependant on error state)
> +// Sleep sleeps for an appropriate interval (dependent on error state)
>  // before sending the Resource to done.
>  func (r *Resource) Sleep(done chan<- *Resource) {
>         time.Sleep(pollInterval + errTimeout*time.Duration(r.**errCount))
> Index: doc/devel/weekly.html
> ==============================**==============================**=======
> --- a/doc/devel/weekly.html
> +++ b/doc/devel/weekly.html
> @@ -2035,7 +2035,7 @@
>  * spec: define order of multiple assignment.
>  * syscall/windows: dll function load and calling changes (thanks Alex
> Brainman).
>  * syscall: add #ifdefs to fix the manual corrections in
> ztypes_linux_arm.go (thanks Dave Cheney),
> -       adjust Mount to accomodate stricter FS implementations.
> +       adjust Mount to accommodate stricter FS implementations.
>  * testing: fix time reported for failing tests.
>  * utf8: add Valid and ValidString.
>  * websocket: tweak hybi ReadHandshake to support Firefox (thanks Luca
> Greco).
> @@ -4362,7 +4362,7 @@
>  To write to standard output, use fmt.Print[ln].
>
>  A new tool, govet, has been added to the Go distribution. Govet is a
> static
> -checker for Go programs. At the moment, and for the forseeable future,
> +checker for Go programs. At the moment, and for the foreseeable future,
>  it only checks arguments to print calls.
>
>  The cgo tool for writing Go bindings for C code has changed so that it no
> Index: src/pkg/net/http/serve_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/serve_test.**go
> +++ b/src/pkg/net/http/serve_test.**go
> @@ -1966,7 +1966,7 @@
>
>  const someResponse = "<html>some response</html>"
>
> -// A Reponse that's just no bigger than 2KB, the buffer-before-chunking
> threshold.
> +// A Response that's just no bigger than 2KB, the buffer-before-chunking
> threshold.
>  var response = bytes.Repeat([]byte(**someResponse),
> 2<<10/len(someResponse))
>
>  // Both Content-Type and Content-Length set. Should be no buffering.
> Index: src/pkg/net/http/server.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/server.go
> +++ b/src/pkg/net/http/server.go
> @@ -1492,7 +1492,7 @@
>
>         // TLSNextProto optionally specifies a function to take over
>         // ownership of the provided TLS connection when an NPN
> -       // protocol upgrade has occured.  The map key is the protocol
> +       // protocol upgrade has occurred.  The map key is the protocol
>         // name negotiated. The Handler argument should be used to
>         // handle HTTP requests and will initialize the Request's TLS
>         // and RemoteAddr if not already set.  The connection is
> Index: src/pkg/runtime/chan.c
> ==============================**==============================**=======
> --- a/src/pkg/runtime/chan.c
> +++ b/src/pkg/runtime/chan.c
> @@ -1011,7 +1011,7 @@
>         c = cas->chan;
>
>         if(c->dataqsiz > 0)
> -               runtime·throw("selectgo: shouldnt happen");
> +               runtime·throw("selectgo: shouldn't happen");
>
>         if(debug)
>                 runtime·printf("wait-return: sel=%p c=%p cas=%p kind=%d\n",
> Index: src/pkg/runtime/os_darwin.c
> ==============================**==============================**=======
> --- a/src/pkg/runtime/os_darwin.c
> +++ b/src/pkg/runtime/os_darwin.c
> @@ -92,7 +92,7 @@
>
>         // Register our thread-creation callback (see
> sys_darwin_{amd64,386}.s)
>         // but only if we're not using cgo.  If we are using cgo we need
> -       // to let the C pthread libary install its own thread-creation
> callback.
> +       // to let the C pthread library install its own thread-creation
> callback.
>         if(!runtime·iscgo) {
>                 if(runtime·bsdthread_register(**) != 0) {
>                         if(runtime·getenv("DYLD_**INSERT_LIBRARIES"))
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[minux1, 2013-04-23 20:38:02]

On Wed, Apr 24, 2013 at 4:31 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> LGTM
>
Thank you, Brad.
I assume I don't need to get another approval from either r or adg for
typo fixes.

btw, at least for me, all my rietveld emails (those sent from
codereview.appspot.com,
e.g. those with the link to the CL page URL at the bottom) are being
classified as
spam by gmail, is this the case for you? How could I fix this?

[bradfitz, 2013-04-23 20:41:13]

On Tue, Apr 23, 2013 at 1:37 PM, minux <minux.ma@gmail.com> wrote:

>
> On Wed, Apr 24, 2013 at 4:31 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote:
>
>> LGTM
>>
> Thank you, Brad.
> I assume I don't need to get another approval from either r or adg for
> typo fixes.
>

This doesn't seem controversial.  Doc cleanups are still fine.


> btw, at least for me, all my rietveld emails (those sent from
> codereview.appspot.com,
> e.g. those with the link to the CL page URL at the bottom) are being
> classified as
> spam by gmail, is this the case for you? How could I fix this?
>

Maybe create a filter in gmail that if it's from
codereview.appspot.comit's marked as not spam?

Or flag them as "Not spam" a few times by hand and it should learn?

[minux1, 2013-04-23 20:46:27]

*** Submitted as https://code.google.com/p/go/source/detail?r=ad7749774783 ***

all: fix typos

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8896045