code review 88900044: net: fix probabilities in DNS SRV shuffleByWeight

net: fix probabilities in DNS SRV shuffleByWeight

Patch from msolo. Just moving it to a CL.
The test fails before and passes with the fix.

Fixes Issue 7098

[bradfitz, 2014-04-17 19:27:45]

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[msolo, 2014-04-17 20:07:55]

On 2014/04/17 19:27:45, bradfitz wrote:
> Hello mailto:rsc@golang.org, mailto:iant@golang.org (cc:
mailto:golang-codereviews@googlegroups.com),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

LGTM. Thanks captain.

[rsc, 2014-04-17 20:25:12]

LGTM

[bradfitz, 2014-04-17 20:28:42]

*** Submitted as https://code.google.com/p/go/source/detail?r=aa556eca5c33 ***

net: fix probabilities in DNS SRV shuffleByWeight

Patch from msolo. Just moving it to a CL.
The test fails before and passes with the fix.

Fixes Issue 7098

LGTM=msolo, rsc
R=rsc, iant, msolo
CC=golang-codereviews
https://codereview.appspot.com/88900044

[gobot, 2014-04-18 07:37:56]

This CL appears to have broken the freebsd-amd64-cheney10 builder.
See http://build.golang.org/log/3b4f4b5de7fc4c5993b75ed7f3afe482b2e125e4

[dave_cheney.net, 2014-04-18 07:52:48]

Ignore this



> On 18 Apr 2014, at 17:37, gobot@golang.org wrote:
> 
> This CL appears to have broken the freebsd-amd64-cheney10 builder.
> See http://build.golang.org/log/3b4f4b5de7fc4c5993b75ed7f3afe482b2e125e4
> 
> https://codereview.appspot.com/88900044/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[minux1, 2014-04-18 16:58:47]

On Apr 18, 2014 3:52 AM, "Dave Cheney" <dave@cheney.net> wrote:
> Ignore this
actually i'm thinking if make.bash should be made smarter to detect that
gcc doesn't exist and try clang.
or at least try clang first on freebsd. Having to set CC always on freebsd
isn't user friendly.
> > On 18 Apr 2014, at 17:37, gobot@golang.org wrote:
> >
> > This CL appears to have broken the freebsd-amd64-cheney10 builder.
> > See http://build.golang.org/log/3b4f4b5de7fc4c5993b75ed7f3afe482b2e125e4