code review 8876043: present: fix get-to-end-of-line code in present's patte...

present: fix get-to-end-of-line code in present's pattern matcher
The old code was wrong: it always advanced before checking
if we were already at end-of-line.

[r, 2013-04-19 20:44:00]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[r, 2013-04-19 20:47:34]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2013-04-19 23:48:13]

add a test?

[r, 2013-04-20 00:23:08]

There need to be tests all through here, but I'm not sure how to go
about it. Can we check this in and address that problem separately?
There is a lousy bug being fixed. I can talk testing with adg when he
returns.

-rob

[dsymonds, 2013-04-20 00:24:20]

LGTM

[r, 2013-04-20 04:30:28]

*** Submitted as
https://code.google.com/p/go/source/detail?r=ba7df7d300f6&repo=talks ***

present: fix get-to-end-of-line code in present's pattern matcher
The old code was wrong: it always advanced before checking
if we were already at end-of-line.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/8876043

[r, 2013-06-19 23:49:27]

*** Abandoned ***