code review 887043: runtime: fix Caller

runtime: fix Caller
log: add test of Caller

New regexp in log test is picky and will require some
maintenance, but it catches off-by-one mistakes too.

Fixes issue 710.

[rsc, 2010-04-06 05:45:24]

Hello gri (cc: esko.luontola@gmail.com, golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-04-06 06:32:28]

LGTM

On Mon, Apr 5, 2010 at 10:45 PM, <rsc@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: esko.luontola@gmail.com, golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> runtime: fix Caller
> log: add test of Caller
>
> New regexp in log test is picky and will require some
> maintenance, but it catches off-by-one mistakes too.
>
> Fixes issue 710.
>
> Please review this at http://codereview.appspot.com/887043/show
>
> Affected files:
>  M src/pkg/log/log_test.go
>  M src/pkg/runtime/runtime.c
>
>
> Index: src/pkg/log/log_test.go
> ===================================================================
> --- a/src/pkg/log/log_test.go
> +++ b/src/pkg/log/log_test.go
> @@ -17,7 +17,7 @@
>        Rdate         = `[0-9][0-9][0-9][0-9]/[0-9][0-9]/[0-9][0-9]`
>        Rtime         = `[0-9][0-9]:[0-9][0-9]:[0-9][0-9]`
>        Rmicroseconds = `\.[0-9][0-9][0-9][0-9][0-9][0-9]`
> -       Rline         = `[0-9]+:`
> +       Rline         = `(58|60):` // must update if the calls to l.Logf /
> l.Log below move
>        Rlongfile     = `.*/[A-Za-z0-9_\-]+\.go:` + Rline
>        Rshortfile    = `[A-Za-z0-9_\-]+\.go:` + Rline
>  )
> Index: src/pkg/runtime/runtime.c
> ===================================================================
> --- a/src/pkg/runtime/runtime.c
> +++ b/src/pkg/runtime/runtime.c
> @@ -479,7 +479,7 @@
>  {
>        Func *f;
>
> -       if(callers(skip, &retpc, 1) == 0 || (f = findfunc(retpc-1)) == nil)
> {
> +       if(callers(1+skip, &retpc, 1) == 0 || (f = findfunc(retpc-1)) ==
> nil) {
>                retfile = emptystring;
>                retline = 0;
>                retbool = false;
>
>
>

[rsc, 2010-04-06 06:36:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=09aefaf3c7a9 ***

runtime: fix Caller
log: add test of Caller

New regexp in log test is picky and will require some
maintenance, but it catches off-by-one mistakes too.

Fixes issue 710.

R=gri
CC=esko.luontola, golang-dev
http://codereview.appspot.com/887043