Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(448)

Issue 887042: code review 887042: programming_faq: added question on T vs *T method sets (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by adg
Modified:
14 years, 12 months ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

programming_faq: added question on T vs *T method sets Adding this question on Russ' recommendation - not sure if there is some detail here I'm missing. The associated discussion was: http://groups.google.com/group/golang-nuts/t/ec6b27e332ed7f77

Patch Set 1 #

Patch Set 2 : code review 887042: programming_faq: added question on T vs *T method sets #

Patch Set 3 : code review 887042: programming_faq: added question on T vs *T method sets #

Total comments: 2

Patch Set 4 : code review 887042: programming_faq: added question on T vs *T method sets #

Patch Set 5 : code review 887042: programming_faq: added question on T vs *T method sets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M doc/go_programming_faq.html View 1 2 3 1 chunk +37 lines, -1 line 0 comments Download

Messages

Total messages: 7
adg
Hello rsc, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 12 months ago (2010-04-05 00:06:44 UTC) #1
adg
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 12 months ago (2010-04-05 00:08:51 UTC) #2
rsc1
Looks good but I'd like to include an example. http://codereview.appspot.com/887042/diff/6001/7001 File doc/go_programming_faq.html (right): http://codereview.appspot.com/887042/diff/6001/7001#newcode130 doc/go_programming_faq.html:130: ...
14 years, 12 months ago (2010-04-05 00:20:25 UTC) #3
adg
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 12 months ago (2010-04-05 00:53:22 UTC) #4
rsc
LGTM but wait for r
14 years, 12 months ago (2010-04-05 02:44:46 UTC) #5
r
LGTM although i doubt this is the end of the issue
14 years, 12 months ago (2010-04-05 06:41:34 UTC) #6
adg
14 years, 12 months ago (2010-04-05 08:17:15 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=a54b92816a65 ***

programming_faq: added question on T vs *T method sets

Adding this question on Russ' recommendation - not sure if
there is some detail here I'm missing.

The associated discussion was:
http://groups.google.com/group/golang-nuts/t/ec6b27e332ed7f77

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/887042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b