LGTM
On Wed, Apr 16, 2014 at 5:02 PM, <r@golang.org> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> flag: document that Bool also accepts "T" and "F"
> Fixes issue 7752.
>
> Please review this at https://codereview.appspot.com/88690043/
>
> Affected files (+2, -1 lines):
> M src/pkg/flag/flag.go
>
>
> Index: src/pkg/flag/flag.go
> ===================================================================
> --- a/src/pkg/flag/flag.go
> +++ b/src/pkg/flag/flag.go
> @@ -50,7 +50,8 @@
> ("-" is a non-flag argument) or after the terminator "--".
>
> Integer flags accept 1234, 0664, 0x1234 and may be negative.
> - Boolean flags may be 1, 0, t, f, true, false, TRUE, FALSE, True,
> False.
> + Boolean flags may be:
> + 1, 0, t, f, T, F, true, false, TRUE, FALSE, True, False
> Duration flags accept any input valid for time.ParseDuration.
>
> The default set of command-line flags is controlled by
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
LGTM
On Wed, Apr 16, 2014 at 5:03 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:
> LGTM
>
>
>
> On Wed, Apr 16, 2014 at 5:02 PM, <r@golang.org> wrote:
>
>> Reviewers: golang-codereviews,
>>
>> Message:
>> Hello golang-codereviews@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> flag: document that Bool also accepts "T" and "F"
>> Fixes issue 7752.
>>
>> Please review this at https://codereview.appspot.com/88690043/
>>
>> Affected files (+2, -1 lines):
>> M src/pkg/flag/flag.go
>>
>>
>> Index: src/pkg/flag/flag.go
>> ===================================================================
>> --- a/src/pkg/flag/flag.go
>> +++ b/src/pkg/flag/flag.go
>> @@ -50,7 +50,8 @@
>> ("-" is a non-flag argument) or after the terminator "--".
>>
>> Integer flags accept 1234, 0664, 0x1234 and may be negative.
>> - Boolean flags may be 1, 0, t, f, true, false, TRUE, FALSE, True,
>> False.
>> + Boolean flags may be:
>> + 1, 0, t, f, T, F, true, false, TRUE, FALSE, True, False
>> Duration flags accept any input valid for time.ParseDuration.
>>
>> The default set of command-line flags is controlled by
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Issue 88690043: code review 88690043: flag: document that Bool also accepts "T" and "F"
(Closed)
Created 10 years ago by r
Modified 10 years ago
Reviewers:
Base URL:
Comments: 0