Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1606)

Issue 8849049: code review 8849049: go.talks/2013/go11: add What's new in Go 1.1 talk (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by adg
Modified:
11 years ago
Reviewers:
CC:
golang-dev, DMorsing, r, dvyukov, binet
Visibility:
Public.

Description

go.talks/2013/go11: add What's new in Go 1.1 talk

Patch Set 1 #

Patch Set 2 : diff -r 3f9bcc8611b2 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 3f9bcc8611b2 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r fec9d4007e12 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r fec9d4007e12 https://code.google.com/p/go.talks #

Patch Set 6 : diff -r fec9d4007e12 https://code.google.com/p/go.talks #

Total comments: 4

Patch Set 7 : diff -r fec9d4007e12 https://code.google.com/p/go.talks #

Total comments: 11

Patch Set 8 : diff -r fec9d4007e12 https://code.google.com/p/go.talks #

Patch Set 9 : diff -r fec9d4007e12 https://code.google.com/p/go.talks #

Patch Set 10 : diff -r cb7d40e26afd https://code.google.com/p/go.talks #

Patch Set 11 : diff -r cb7d40e26afd https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1133 lines, -0 lines) Patch
A 2013/go1.1.slide View 1 2 3 4 5 6 7 8 9 1 chunk +243 lines, -0 lines 0 comments Download
A 2013/go1.1/blockprofile.png View 1 2 3 4 5 6 7 Binary file 0 comments Download
A 2013/go1.1/blockprofile.svg View 1 2 3 4 5 6 7 1 chunk +615 lines, -0 lines 0 comments Download
A 2013/go1.1/chanof.go View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A 2013/go1.1/intdiv.go View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A 2013/go1.1/makefunc.go View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A 2013/go1.1/methodvals.go View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A 2013/go1.1/methodvals-old.go View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A 2013/go1.1/race.go View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A 2013/go1.1/reflect.go View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
A 2013/go1.1/return.go View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A 2013/go1.1/return-old.go View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A 2013/go1.1/scanner.go View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A 2013/go1.1/scanner2.go View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A 2013/go1.1/timer.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +37 lines, -0 lines 0 comments Download
A 2013/go1.1/yearday.go View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
11 years ago (2013-04-30 13:26:35 UTC) #1
DMorsing
https://codereview.appspot.com/8849049/diff/15001/2013/go1.1.slide File 2013/go1.1.slide (right): https://codereview.appspot.com/8849049/diff/15001/2013/go1.1.slide#newcode123 2013/go1.1.slide:123: The `go`run` command now runs all files in the ...
11 years ago (2013-04-30 15:09:56 UTC) #2
r
https://codereview.appspot.com/8849049/diff/20001/2013/go1.1.slide File 2013/go1.1.slide (right): https://codereview.appspot.com/8849049/diff/20001/2013/go1.1.slide#newcode35 2013/go1.1.slide:35: Sometimes you want to turn a method into a ...
11 years ago (2013-04-30 16:54:28 UTC) #3
dvyukov
https://codereview.appspot.com/8849049/diff/20001/2013/go1.1.slide File 2013/go1.1.slide (right): https://codereview.appspot.com/8849049/diff/20001/2013/go1.1.slide#newcode81 2013/go1.1.slide:81: .play go1.1/race.go if you want to show the report, ...
11 years ago (2013-04-30 17:12:52 UTC) #4
binet
typo https://codereview.appspot.com/8849049/diff/20001/2013/go1.1.slide File 2013/go1.1.slide (right): https://codereview.appspot.com/8849049/diff/20001/2013/go1.1.slide#newcode238 2013/go1.1.slide:238: - In-ling of small functions by the gc ...
11 years ago (2013-05-01 11:15:09 UTC) #5
adg
PTAL https://codereview.appspot.com/8849049/diff/15001/2013/go1.1.slide File 2013/go1.1.slide (right): https://codereview.appspot.com/8849049/diff/15001/2013/go1.1.slide#newcode123 2013/go1.1.slide:123: The `go`run` command now runs all files in ...
11 years ago (2013-05-02 13:26:12 UTC) #6
r
LGTM
11 years ago (2013-05-09 23:14:36 UTC) #7
adg
11 years ago (2013-05-10 17:17:39 UTC) #8
*** Submitted as
https://code.google.com/p/go/source/detail?r=7597f5c52a13&repo=talks ***

go.talks/2013/go11: add What's new in Go 1.1 talk

R=golang-dev, daniel.morsing, r, dvyukov, seb.binet
CC=golang-dev
https://codereview.appspot.com/8849049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b