Issue 883046: code review 883046: arm: fix build, attempt #1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 883046: code review 883046: arm: fix build, attempt #1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by rsc

Modified:
14 years, 11 months ago

Reviewers:

CC:
kaib, golang-dev

Visibility:
Public.

Description

arm: fix build, attempt #1

Patch Set 1 #

Patch Set 2 : code review 883046: arm: fix build, attempt #1 #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -81 lines)			Patch
M	test/arm-pass.txt	View		18 chunks	+73 lines, -16 lines	0 comments	Download
M	test/golden-arm.out	View	1	2 chunks	+66 lines, -64 lines	0 comments	Download
M	test/run-arm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello kaib (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-04-07 00:56:46 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=802e6afddbb7 *** arm: fix build, attempt #1 TBR=kaib CC=golang-dev http://codereview.appspot.com/883046

14 years, 11 months ago (2010-04-07 00:56:51 UTC) #2

kaib

14 years, 11 months ago (2010-04-07 09:05:07 UTC) #3

lgtm

the fail annotations are good.

On Wed, Apr 7, 2010 at 3:56 AM,  <rsc@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=802e6afddbb7 ***
>
> arm: fix build, attempt #1
>
> TBR=kaib
> CC=golang-dev
> http://codereview.appspot.com/883046
>
>
> http://codereview.appspot.com/883046/show
>

Expand All Messages | Collapse All Messages