Issue 88160050: code review 88160050: go/scanner: interpret //line directives sans filename s...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88160050: code review 88160050: go/scanner: interpret //line directives sans filename s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by adonovan

Modified:
10 years ago

Reviewers:
rsc, gri

CC:
rsc, gri, golang-codereviews

Visibility:
Public.

Description

go/scanner: interpret //line directives sans filename sensibly, second try. A //line directive without a filename now denotes the empty filename, not the current directory (the Go 1.2 behaviour) nor the previous //line's filename (the behaviour since CL 86990044). They should never appear (but they do, e.g. due to a bug in godoc). Fixes issue 7765

Patch Set 1 #

Patch Set 2 : diff -r b661b5f1787a https://code.google.com/p/go/ #

Patch Set 3 : diff -r b661b5f1787a https://code.google.com/p/go/ #

Patch Set 4 : diff -r b69c41540134 https://code.google.com/p/go/ #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	src/pkg/go/scanner/scanner.go	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
	M	src/pkg/go/scanner/scanner_test.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adonovan

Hello rsc@golang.org, gri@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years ago (2014-04-16 19:21:01 UTC) #1

adonovan

10 years ago (2014-04-16 20:17:53 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=738877993c83 ***

go/scanner: interpret //line directives sans filename sensibly, second try.

A //line directive without a filename now denotes the empty
filename, not the current directory (the Go 1.2 behaviour) nor
the previous //line's filename (the behaviour since CL
86990044).

They should never appear (but they do, e.g. due to a bug in godoc).

Fixes issue 7765

LGTM=gri, rsc
R=rsc, gri
CC=golang-codereviews
https://codereview.appspot.com/88160050

Expand All Messages | Collapse All Messages