Issue 880043: code review 880043: runtime: fix bug in GOMAXPROCS when trying to cut numbe...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 880043: code review 880043: runtime: fix bug in GOMAXPROCS when trying to cut numbe... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 12 months ago by rsc

Modified:
14 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

runtime: two proc bug fixes 1. Fix bug in GOMAXPROCS when trying to cut number of procs Race could happen on any system but was manifesting only on Xen hosted Linux. 2. Fix recover on ARM, where FP != caller SP.

Patch Set 1 #

Patch Set 2 : code review 880043: runtime: fix bug in GOMAXPROCS when trying to cut numbe... #

Patch Set 3 : code review 880043: runtime: fix bug in GOMAXPROCS when trying to cut numbe... #

Patch Set 4 : code review 880043: runtime: two proc bug fixes #

Patch Set 5 : code review 880043: runtime: two proc bug fixes #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
	M	src/pkg/runtime/proc.c	View	1 2 3	3 chunks	+13 lines, -6 lines	0 comments	Download
	M	test/recover2.go	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 12 months ago (2010-04-05 23:48:10 UTC) #1

rsc

PTAL uploaded On Tue, Apr 6, 2010 at 11:41, <r@golang.org> wrote: > i don't see ...

14 years, 11 months ago (2010-04-06 18:46:26 UTC) #3

rsc

the call to getcallersp is what fixes the arm. On Tue, Apr 6, 2010 at ...

14 years, 11 months ago (2010-04-06 20:37:18 UTC) #5

rsc

the call to getcallersp is what fixes the arm. getcallersp is a no-op on non-arm ...

14 years, 11 months ago (2010-04-06 20:37:38 UTC) #6

rsc

14 years, 11 months ago (2010-04-06 20:48:35 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=d403007a8e4b ***

runtime: two proc bug fixes

1. Fix bug in GOMAXPROCS when trying to cut number of procs
Race could happen on any system but was
manifesting only on Xen hosted Linux.

2. Fix recover on ARM, where FP != caller SP.

R=r
CC=golang-dev
http://codereview.appspot.com/880043

Expand All Messages | Collapse All Messages