code review 87890045: go.blog: fix build; addg "// +build OMIT" to many samples

go.blog: fix build; add "// +build OMIT" to many samples

We use OMIT instead of ignore so such lines will be omitted
from present output.

[adg, 2014-04-15 00:51:58]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.blog

[adg, 2014-04-15 01:00:49]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[bradfitz, 2014-04-15 01:38:12]

LGTM
On Apr 14, 2014 6:00 PM, <adg@golang.org> wrote:

> Hello golang-codereviews@googlegroups.com (cc:
> golang-codereviews@googlegroups.com),
>
> Please take another look.
>
>
> https://codereview.appspot.com/87890045/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[bradfitz, 2014-04-15 01:38:28]

LGTM
 On Apr 14, 2014 5:52 PM, <adg@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.blog
>
>
> Description:
> go.blog: fix build; addg "// +build ignore" to many samples
>
> Please review this at https://codereview.appspot.com/87890045/
>
> Affected files (+76, -0 lines):
>   M content/go-maps-in-action/list.go
>   M content/go-maps-in-action/people.go
>   M content/pipelines/bounded.go
>   M content/pipelines/parallel.go
>   M content/pipelines/serial.go
>   M content/pipelines/sqbuffer.go
>   M content/pipelines/sqdone1.go
>   M content/pipelines/sqdone2.go
>   M content/pipelines/sqdone3.go
>   M content/pipelines/sqfan.go
>   M content/pipelines/sqleak.go
>   M content/pipelines/square.go
>   M content/pipelines/square2.go
>   M content/playground/net.go
>   M content/playground/os.go
>   M content/playground/time.go
>   M content/race-detector/blackhole.go
>   M content/race-detector/timer.go
>   M content/race-detector/timer-fixed.go
>   M content/slices/prog010.go
>   M content/slices/prog020.go
>   M content/slices/prog030.go
>   M content/slices/prog040.go
>   M content/slices/prog050.go
>   M content/slices/prog060.go
>   M content/slices/prog070.go
>   M content/slices/prog080.go
>   M content/slices/prog090.go
>   M content/slices/prog100.go
>   M content/slices/prog110.go
>   M content/slices/prog120.go
>   M content/slices/prog130.go
>   M content/slices/prog140.go
>   M content/slices/prog150.go
>   M content/strings/basic.go
>   M content/strings/encoding.go
>   M content/strings/range.go
>   M content/strings/utf8.go
>
>
> Index: content/go-maps-in-action/list.go
> ===================================================================
> --- a/content/go-maps-in-action/list.go
> +++ b/content/go-maps-in-action/list.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build ignore
> +
>  package main
>
>  import "fmt"
> Index: content/go-maps-in-action/people.go
> ===================================================================
> --- a/content/go-maps-in-action/people.go
> +++ b/content/go-maps-in-action/people.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build ignore
> +
>  package main
>
>  import "fmt"
> Index: content/pipelines/bounded.go
> ===================================================================
> --- a/content/pipelines/bounded.go
> +++ b/content/pipelines/bounded.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/pipelines/parallel.go
> ===================================================================
> --- a/content/pipelines/parallel.go
> +++ b/content/pipelines/parallel.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/pipelines/serial.go
> ===================================================================
> --- a/content/pipelines/serial.go
> +++ b/content/pipelines/serial.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/pipelines/sqbuffer.go
> ===================================================================
> --- a/content/pipelines/sqbuffer.go
> +++ b/content/pipelines/sqbuffer.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/pipelines/sqdone1.go
> ===================================================================
> --- a/content/pipelines/sqdone1.go
> +++ b/content/pipelines/sqdone1.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/pipelines/sqdone2.go
> ===================================================================
> --- a/content/pipelines/sqdone2.go
> +++ b/content/pipelines/sqdone2.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/pipelines/sqdone3.go
> ===================================================================
> --- a/content/pipelines/sqdone3.go
> +++ b/content/pipelines/sqdone3.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/pipelines/sqfan.go
> ===================================================================
> --- a/content/pipelines/sqfan.go
> +++ b/content/pipelines/sqfan.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/pipelines/sqleak.go
> ===================================================================
> --- a/content/pipelines/sqleak.go
> +++ b/content/pipelines/sqleak.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/pipelines/square.go
> ===================================================================
> --- a/content/pipelines/square.go
> +++ b/content/pipelines/square.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import "fmt"
> Index: content/pipelines/square2.go
> ===================================================================
> --- a/content/pipelines/square2.go
> +++ b/content/pipelines/square2.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import "fmt"
> Index: content/playground/net.go
> ===================================================================
> --- a/content/playground/net.go
> +++ b/content/playground/net.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/playground/os.go
> ===================================================================
> --- a/content/playground/os.go
> +++ b/content/playground/os.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/playground/time.go
> ===================================================================
> --- a/content/playground/time.go
> +++ b/content/playground/time.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/race-detector/blackhole.go
> ===================================================================
> --- a/content/race-detector/blackhole.go
> +++ b/content/race-detector/blackhole.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  var blackHole [4096]byte // shared buffer
> Index: content/race-detector/timer-fixed.go
> ===================================================================
> --- a/content/race-detector/timer-fixed.go
> +++ b/content/race-detector/timer-fixed.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/race-detector/timer.go
> ===================================================================
> --- a/content/race-detector/timer.go
> +++ b/content/race-detector/timer.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  package main
>
>  import (
> Index: content/slices/prog010.go
> ===================================================================
> --- a/content/slices/prog010.go
> +++ b/content/slices/prog010.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog020.go
> ===================================================================
> --- a/content/slices/prog020.go
> +++ b/content/slices/prog020.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog030.go
> ===================================================================
> --- a/content/slices/prog030.go
> +++ b/content/slices/prog030.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog040.go
> ===================================================================
> --- a/content/slices/prog040.go
> +++ b/content/slices/prog040.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog050.go
> ===================================================================
> --- a/content/slices/prog050.go
> +++ b/content/slices/prog050.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog060.go
> ===================================================================
> --- a/content/slices/prog060.go
> +++ b/content/slices/prog060.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog070.go
> ===================================================================
> --- a/content/slices/prog070.go
> +++ b/content/slices/prog070.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog080.go
> ===================================================================
> --- a/content/slices/prog080.go
> +++ b/content/slices/prog080.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog090.go
> ===================================================================
> --- a/content/slices/prog090.go
> +++ b/content/slices/prog090.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog100.go
> ===================================================================
> --- a/content/slices/prog100.go
> +++ b/content/slices/prog100.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog110.go
> ===================================================================
> --- a/content/slices/prog110.go
> +++ b/content/slices/prog110.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog120.go
> ===================================================================
> --- a/content/slices/prog120.go
> +++ b/content/slices/prog120.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog130.go
> ===================================================================
> --- a/content/slices/prog130.go
> +++ b/content/slices/prog130.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog140.go
> ===================================================================
> --- a/content/slices/prog140.go
> +++ b/content/slices/prog140.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/slices/prog150.go
> ===================================================================
> --- a/content/slices/prog150.go
> +++ b/content/slices/prog150.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/strings/basic.go
> ===================================================================
> --- a/content/strings/basic.go
> +++ b/content/strings/basic.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/strings/encoding.go
> ===================================================================
> --- a/content/strings/encoding.go
> +++ b/content/strings/encoding.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/strings/range.go
> ===================================================================
> --- a/content/strings/range.go
> +++ b/content/strings/range.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> Index: content/strings/utf8.go
> ===================================================================
> --- a/content/strings/utf8.go
> +++ b/content/strings/utf8.go
> @@ -1,3 +1,5 @@
> +// +build ignore
> +
>  // Copyright 2013 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[adg, 2014-04-15 01:43:44]

*** Submitted as
https://code.google.com/p/go/source/detail?r=bfa8608b2028&repo=blog ***

go.blog: fix build; add "// +build OMIT" to many samples

We use OMIT instead of ignore so such lines will be omitted
from present output.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/87890045