code review 87860043: go.blog: use !info.Mode().IsRegular() instead of info.I...

go.blog: use !info.Mode().IsRegular() instead of info.Isdir()

That way we'll only try to hash regular files.

Fixes issue 7770.

[adg, 2014-04-14 23:46:57]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.blog

[bradfitz, 2014-04-14 23:47:32]

LGTM



On Mon, Apr 14, 2014 at 4:46 PM, <adg@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.blog
>
>
> Description:
> go.blog: use !info.Mode().IsRegular() instead of info.Isdir()
>
> That way we'll only try to hash regular files.
>
> Fixes issue 7770.
>
> Please review this at https://codereview.appspot.com/87860043/
>
> Affected files (+3, -3 lines):
>   M content/pipelines/bounded.go
>   M content/pipelines/parallel.go
>   M content/pipelines/serial.go
>
>
> Index: content/pipelines/bounded.go
> ===================================================================
> --- a/content/pipelines/bounded.go
> +++ b/content/pipelines/bounded.go
> @@ -25,7 +25,7 @@
>                         if err != nil {
>                                 return err
>                         }
> -                       if info.IsDir() {
> +                       if !info.Mode().IsRegular() {
>                                 return nil
>                         }
>                         select {
> Index: content/pipelines/parallel.go
> ===================================================================
> --- a/content/pipelines/parallel.go
> +++ b/content/pipelines/parallel.go
> @@ -33,7 +33,7 @@
>                         if err != nil {
>                                 return err
>                         }
> -                       if info.IsDir() {
> +                       if !info.Mode().IsRegular() {
>                                 return nil
>                         }
>                         wg.Add(1)
> Index: content/pipelines/serial.go
> ===================================================================
> --- a/content/pipelines/serial.go
> +++ b/content/pipelines/serial.go
> @@ -18,7 +18,7 @@
>                 if err != nil {
>                         return err
>                 }
> -               if info.IsDir() {
> +               if !info.Mode().IsRegular() {
>                         return nil
>                 }
>                 data, err := ioutil.ReadFile(path) // HL
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[adg, 2014-04-14 23:48:48]

*** Submitted as
https://code.google.com/p/go/source/detail?r=08c91d5f3550&repo=blog ***

go.blog: use !info.Mode().IsRegular() instead of info.Isdir()

That way we'll only try to hash regular files.

Fixes issue 7770.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/87860043