code review 87770048: cmd/ld: populate pe symbol table with Go symbols

cmd/ld: populate pe symbol table with Go symbols

Fixes issue 6936

[brainman, 2014-04-16 07:02:36]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2014-04-16 07:03:35]

I have used this reference
http://pierrelib.pagesperso-orange.fr/exec_formats/DJGPP_COFF.html to write my
code.

I am not sure if I am filtering symbols properly in addsym. Perhaps I include
too many. Perhaps I miss some. For example, nm.exe size went up for me from
2458112 and to 2625536.

Perhaps I should rewrite some symbol names (I don't at this moment). I'm not
sure what might get affected.

I also bit concerned about marking all symbols as 0x0308 / "array of structs".
That is how the code was, and I'm leaving it as is. We can try to use types
listed in DJGPP_COFF.html, but I would struggle with mapping it. And I'm not
sure about the benefit.

Alex

[bradfitz, 2014-04-16 18:26:42]

R=rsc



On Wed, Apr 16, 2014 at 12:02 AM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/ld: populate pe symbol table with Go symbols
>
> Fixes issue 6936
>
> Please review this at https://codereview.appspot.com/87770048/
>
> Affected files (+97, -29 lines):
>   M src/cmd/ld/pe.c
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-04-17 02:25:32]

LGTM

I patched this in and ran it on a windows net/http test binary, and
compared the output against OS X. It looks roughly the same. In fact it
turned up bugs in the OS X listing, but the Windows one looks great.

Thanks.
Russ

[rsc, 2014-04-17 02:25:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=36eb4a62fbb6 ***

cmd/ld: populate pe symbol table with Go symbols

Fixes issue 6936

LGTM=rsc
R=golang-codereviews, bradfitz, rsc
CC=golang-codereviews
https://codereview.appspot.com/87770048

Committer: Russ Cox <rsc@golang.org>