code review 87670045: crypto/x509: support SHA-512 by default.

crypto/x509: support SHA-512 by default.

Comodo are now using a SHA-384 signed intermediate. The crypto/x509
package seeks to import hash functions needed for typical operation
without needing to import every hash function possible. Since a SHA-384
certificate is being used by Comodo, crypto/sha512 now appears to fall
into the scope of "typical operation".

R=bradfitz

[agl1, 2014-04-14 19:06:51]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-04-14 19:09:11]

LGTM



On Mon, Apr 14, 2014 at 12:06 PM, <agl@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> crypto/x509: support SHA-512 by default.
>
> Comodo are now using a SHA-384 signed intermediate. The crypto/x509
> package seeks to import hash functions needed for typical operation
> without needing to import every hash function possible. Since a SHA-384
> certificate is being used by Comodo, crypto/sha512 now appears to fall
> into the scope of "typical operation".
>
> R=bradfitz
>
> Please review this at https://codereview.appspot.com/87670045/
>
> Affected files (+124, -0 lines):
>   M src/pkg/crypto/x509/verify_test.go
>   M src/pkg/crypto/x509/x509.go
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[agl1, 2014-04-14 19:12:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=8aad251d4bd1 ***

crypto/x509: support SHA-512 by default.

Comodo are now using a SHA-384 signed intermediate. The crypto/x509
package seeks to import hash functions needed for typical operation
without needing to import every hash function possible. Since a SHA-384
certificate is being used by Comodo, crypto/sha512 now appears to fall
into the scope of "typical operation".

R=bradfitz

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/87670045

[gobot, 2014-04-14 19:44:58]

This CL appears to have broken the windows-amd64 builder.
See http://build.golang.org/log/b1e7559dd847e3ebaa3e0f0a50dcb6de780870d4

[bradfitz, 2014-04-14 19:46:51]

Broke both Windows builders. Looks real.



On Mon, Apr 14, 2014 at 12:44 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the windows-amd64 builder.
> See http://build.golang.org/log/b1e7559dd847e3ebaa3e0f0a50dcb6de780870d4
>
> https://codereview.appspot.com/87670045/
>

[agl1, 2014-04-14 20:05:44]

On Mon, Apr 14, 2014 at 12:46 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Broke both Windows builders. Looks real.

Fixing. Just a question of chain truncation.


Cheers

AGL