code review 87640043: net/http: make race detector happy for recently-added test

net/http: make race detector happy for recently-added test

Update Issue 7264

Races:
http://build.golang.org/log/a2e401fdcd4903a61a3375bff5da702a20ddafad
http://build.golang.org/log/ec4c69e92076a747ac6d5df7eb7b382b31ab3d43

I think this is the first time I've actually seen a manifestation
of Issue 7264, and one that I can reproduce.

I don't know why it triggers on this test and not any others
just like it, or why I can't reproduce Issue 7264
independently, even when Dmitry gives me minimal repros.

Work around it for now with some synchronization to make the
race detector happy.

The proper fix will probably be in net/http/httptest itself, not
in all hundred some tests.

[bradfitz, 2014-04-14 15:56:28]

Hello rsc@golang.org (cc: dvyukov@google.com,
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2014-04-14 18:10:08]

LGTM

[bradfitz, 2014-04-14 19:08:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=d76edbf70414 ***

net/http: make race detector happy for recently-added test

Update Issue 7264

Races:
http://build.golang.org/log/a2e401fdcd4903a61a3375bff5da702a20ddafad
http://build.golang.org/log/ec4c69e92076a747ac6d5df7eb7b382b31ab3d43

I think this is the first time I've actually seen a manifestation
of Issue 7264, and one that I can reproduce.

I don't know why it triggers on this test and not any others
just like it, or why I can't reproduce Issue 7264
independently, even when Dmitry gives me minimal repros.

Work around it for now with some synchronization to make the
race detector happy.

The proper fix will probably be in net/http/httptest itself, not
in all hundred some tests.

LGTM=rsc
R=rsc
CC=dvyukov, golang-codereviews
https://codereview.appspot.com/87640043

[gobot, 2014-04-14 19:27:26]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/b2b628a15953a4e1bce1f2db86de92a4244337f6