code review 8763044: archive/tar: skip NUL-filled unused octal fields

archive/tar: skip NUL-filled unused octal fields
Fixes issue 5290.

[dave_cheney.net, 2013-04-25 00:49:25]

ping

[bradfitz, 2013-04-25 02:33:34]

https://codereview.appspot.com/8763044/diff/8001/src/pkg/archive/tar/reader.go
File src/pkg/archive/tar/reader.go (right):

https://codereview.appspot.com/8763044/diff/8001/src/pkg/archive/tar/reader.g...
src/pkg/archive/tar/reader.go:249: for len(b) > 0 && (b[0] == ' ' || b[0] ==
'\x00') {
these two loops could be combined now to just:

// Remove leading and trailing spaces and NULL bytes.
b = bytes.Trim(b, " \x00")

[minux1, 2013-04-25 04:00:25]

On Thursday, April 25, 2013, wrote:

> ping
>
i was waiting because i assumed this is not important enough
for Go 1.1...
will send it out today after addressing Brad's comments.

[minux1, 2013-04-25 12:11:40]

Hello golang-dev@googlegroups.com, dave@cheney.net, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-04-25 17:00:38]

LGTM after go1.1, unless r says 1.1.

Considering that I have an Eye-Fi card, I'd at least be find with including
this in go1.1.  We seem to have a good test.




On Thu, Apr 25, 2013 at 5:11 AM, <minux.ma@gmail.com> wrote:

> Hello golang-dev@googlegroups.com, dave@cheney.net, bradfitz@golang.org
> (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
>
https://codereview.appspot.**com/8763044/<https://codereview.appspot.com/8763...
>

[minux1, 2013-05-14 19:47:22]

On 2013/04/25 17:00:38, bradfitz wrote:
> LGTM after go1.1, unless r says 1.1.
ok to check in now?

[r, 2013-05-14 20:00:24]

LGTM

[minux1, 2013-05-14 20:40:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=3a896cbee85f ***

archive/tar: skip NUL-filled unused octal fields
Fixes issue 5290.

R=golang-dev, dave, bradfitz, r
CC=golang-dev
https://codereview.appspot.com/8763044