Issue 87510043: code review 87510043: ogle/program/server: trace multiple frames.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 87510043: code review 87510043: ogle/program/server: trace multiple frames. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by nigeltao

Modified:
10 years ago

Reviewers:
r

CC:
r

Visibility:
Public.

Description

ogle/program/server: trace multiple frames.

Patch Set 1 #

Patch Set 2 : diff -r e59459afd802 https://code.google.com/p/ogle #

Patch Set 3 : diff -r e59459afd802 https://code.google.com/p/ogle #

Total comments: 1

Patch Set 4 : diff -r e59459afd802 https://code.google.com/p/ogle #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -65 lines)			Patch
M	arch/arch.go	View	1	3 chunks	+16 lines, -3 lines	0 comments	Download
M	gosym/pclntab.go	View	1	2 chunks	+11 lines, -2 lines	0 comments	Download
M	gosym/symtab.go	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download
M	program/server/server.go	View	1 2 3	3 chunks	+68 lines, -60 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle

10 years ago (2014-04-14 09:22:28 UTC) #1

LGTM by the way, i have the dwarf pc-line table decoder working, just need to ...

10 years ago (2014-04-14 17:43:25 UTC) #2

nigeltao

10 years ago (2014-04-16 01:44:37 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=3ade69b38442 ***

ogle/program/server: trace multiple frames.

LGTM=r
R=r
https://codereview.appspot.com/87510043

Expand All Messages | Collapse All Messages