Issue 875048: code review 875048: gc: cmplx typecheck bug fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 875048: code review 875048: gc: cmplx typecheck bug fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by rsc

Modified:
14 years, 11 months ago

Reviewers:
ken3, cw

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: cmplx typecheck bug fix Fixes issue 729.

Patch Set 2 : code review 875048: gc: cmplx typecheck bug fix #

Total comments: 1

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -1 line)			Patch
	M	src/cmd/gc/typecheck.c	View		1 chunk	+1 line, -1 line	1 comment	Download
	A	test/cmplx.go	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-04-19 16:21:49 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=dc0f81c41f04 *** gc: cmplx typecheck bug fix Fixes issue 729. R=ken2 CC=golang-dev ...

14 years, 11 months ago (2010-04-19 16:22:11 UTC) #2

q: http://codereview.appspot.com/875048/diff/2001/3001 File src/cmd/gc/typecheck.c (left): http://codereview.appspot.com/875048/diff/2001/3001#oldcode793 src/cmd/gc/typecheck.c:793: if(l->type->etype != l->type->etype) { Does the compiler not ...

14 years, 11 months ago (2010-04-19 18:03:48 UTC) #3

rsc

14 years, 11 months ago (2010-04-20 14:16:40 UTC) #5

On Mon, Apr 19, 2010 at 11:03,  <cw@f00f.org> wrote:
> q:
>
> http://codereview.appspot.com/875048/diff/2001/3001#oldcode793
> src/cmd/gc/typecheck.c:793: if(l->type->etype != l->type->etype) {
> Does the compiler not warn for things like this?

apparently not.

Expand All Messages | Collapse All Messages