Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(376)

Issue 875045: code review 875045: netchan: allow client to send as well as receive. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by r
Modified:
14 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

netchan: allow client to send as well as receive. much rewriting and improving, but it's still experimental.

Patch Set 1 #

Patch Set 2 : code review 875045: netchan: allow client to send as well as receive. #

Patch Set 3 : code review 875045: netchan: allow client to send as well as receive. #

Patch Set 4 : code review 875045: netchan: allow client to send as well as receive. #

Patch Set 5 : code review 875045: netchan: allow client to send as well as receive. #

Total comments: 2

Patch Set 6 : code review 875045: netchan: allow client to send as well as receive. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -124 lines) Patch
M src/pkg/netchan/common.go View 1 4 chunks +43 lines, -19 lines 0 comments Download
M src/pkg/netchan/export.go View 1 2 3 4 5 7 chunks +89 lines, -62 lines 0 comments Download
M src/pkg/netchan/import.go View 1 2 3 7 chunks +53 lines, -30 lines 0 comments Download
M src/pkg/netchan/netchan_test.go View 1 2 chunks +58 lines, -13 lines 0 comments Download

Messages

Total messages: 4
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 1 month ago (2010-04-13 05:23:29 UTC) #1
rsc1
LGTM Should the Send request need to have an ack response before doing the sends? ...
14 years, 1 month ago (2010-04-13 20:45:21 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=166711b7c8ee *** netchan: allow client to send as well as receive. much ...
14 years, 1 month ago (2010-04-13 20:49:46 UTC) #3
r2
14 years, 1 month ago (2010-04-13 20:50:57 UTC) #4
On Apr 13, 2010, at 1:45 PM, rsc@google.com wrote:

> LGTM
>
> Should the Send request need to have an ack response before doing the
> sends?

that delays for another transmission time.  maybe. i haven't decided  
exactly how this should work yet.
for consideration in the next round.

-rob


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b