code review 875043: net: use chan bool instead of chan *netFD to avoid cycle

net: use chan bool instead of chan *netFD to avoid cycle

The cycle is *netFD -> cw chanl *netFD in struct ->
same *netFD in channel read buffer.

Because channels are finalized, the cycle makes them
uncollectable.  A better fix is to make channels not
finalized anymore, and that will happen, but this is
an easy, reasonable workaround until then.

Another good fix would be to zero the channel receive
buffer entry after the receive.  That too will happen.

[rsc, 2010-04-06 23:28:58]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-04-06 23:30:27]

LGTM

[rsc, 2010-04-06 23:50:30]

*** Submitted as http://code.google.com/p/go/source/detail?r=f4bb3941e621 ***

net: use chan bool instead of chan *netFD to avoid cycle

The cycle is *netFD -> cw chanl *netFD in struct ->
same *netFD in channel read buffer.

Because channels are finalized, the cycle makes them
uncollectable.  A better fix is to make channels not
finalized anymore, and that will happen, but this is
an easy, reasonable workaround until then.

Another good fix would be to zero the channel receive
buffer entry after the receive.  That too will happen.

R=r
CC=golang-dev
http://codereview.appspot.com/875043