code review 875041: runtime: correct memory leak in select

runtime: correct memory leak in select
  * adds pass 3 to dequeue from channels eagerly

various other cleanup/churn:
  * use switch on cas->send in each pass to
    factor out common code.
  * longer goto labels, commented at target
  * be more agressive about can't happen:
    throw instead of print + cope.
  * use "select" instead of "selectgo" in errors
  * use printf for debug prints when possible

[rsc, 2010-04-01 08:11:06]

Hello ken2 (cc: golang-dev@googlegroups.com, r),

I'd like you to review this change.

[ken3, 2010-04-01 18:51:03]

LGTM

On 2010/04/01 08:11:06, rsc wrote:
> Hello ken2 (cc: mailto:golang-dev@googlegroups.com, r),
> 
> I'd like you to review this change.

[rsc, 2010-04-01 18:56:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=81ccd24eb407 ***

runtime: correct memory leak in select
  * adds pass 3 to dequeue from channels eagerly

various other cleanup/churn:
  * use switch on cas->send in each pass to
    factor out common code.
  * longer goto labels, commented at target
  * be more agressive about can't happen:
    throw instead of print + cope.
  * use "select" instead of "selectgo" in errors
  * use printf for debug prints when possible

R=ken2, ken3
CC=golang-dev, r
http://codereview.appspot.com/875041

[ken3, 2010-04-05 23:13:29]

LGTM