Issue 87420043: code review 87420043: encoding/json: document Encoder will terminate each JSO...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 87420043: code review 87420043: encoding/json: document Encoder will terminate each JSO... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by minux1

Modified:
10 years ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

encoding/json: document Encoder will terminate each JSON value with '\n' Fixes issue 7767.

Patch Set 2 : diff -r b3405f9c2e32 https://code.google.com/p/go #

Patch Set 3 : diff -r b3405f9c2e32 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r b3405f9c2e32 https://code.google.com/p/go #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/encoding/json/stream.go	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years ago (2014-04-13 17:53:05 UTC) #1

rsc

LGTM https://codereview.appspot.com/87420043/diff/40001/src/pkg/encoding/json/stream.go File src/pkg/encoding/json/stream.go (left): https://codereview.appspot.com/87420043/diff/40001/src/pkg/encoding/json/stream.go#oldcode151 src/pkg/encoding/json/stream.go:151: // Encode writes the JSON encoding of v ...

10 years ago (2014-04-13 23:29:14 UTC) #2

rsc

10 years ago (2014-04-17 02:42:33 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4d3e80a4979d ***

encoding/json: document Encoder will terminate each JSON value with '\n'
Fixes issue 7767.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/87420043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages