code review 871042: runtime: turn run time errors checks into panics

runtime: turn run time errors checks into panics

[rsc, 2010-04-01 08:10:58]

Hello ken2 (cc: golang-dev@googlegroups.com, r),

I'd like you to review this change.

[r, 2010-04-02 03:59:19]

LGTM

http://codereview.appspot.com/871042/diff/5001/6020
File src/pkg/runtime/error.go (right):

http://codereview.appspot.com/871042/diff/5001/6020#newcode10
src/pkg/runtime/error.go:10: RuntimeError() // no-op that uniquely identifies
runtime.Error
worth better a comment - // This is here to distinguish it from other interfaces
containing only String()

http://codereview.appspot.com/871042/diff/5001/6023
File src/pkg/runtime/runtime.c (right):

http://codereview.appspot.com/871042/diff/5001/6023#newcode65
src/pkg/runtime/runtime.c:65: {
both these two comments seem relevant enough to put in the message

[rsc, 2010-04-02 05:31:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=173e1c995750 ***

runtime: turn run time errors checks into panics

R=ken2, r
CC=golang-dev
http://codereview.appspot.com/871042

Committer: Russ Cox <rsc@golang.org>

[ken3, 2010-04-05 23:10:13]

LGTM