LGTM
On Thu, Apr 25, 2013 at 7:36 AM, <adg@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**talks <https://code.google.com/p/go.talks>
>
>
> Description:
> go.talks/2012/chat: some minor cleanups
>
> Please review this at
https://codereview.appspot.**com/8695050/<https://codereview.appspot.com/8695...
>
> Affected files:
> M 2012/chat.slide
>
>
> Index: 2012/chat.slide
> ==============================**==============================**=======
> --- a/2012/chat.slide
> +++ b/2012/chat.slide
> @@ -93,7 +93,7 @@
>
> * Goroutines
>
> -Goroutines are lightweight threads that are managed by the Go runtime. To
> run a function in a new goroutine, just put "`go`" before the function call.
> +Goroutines are lightweight threads that are managed by the Go runtime. To
> run a function in a new goroutine, just put `"go"` before the function call.
>
> .play chat/support/goroutines.go
>
> @@ -125,7 +125,7 @@
>
> * Channels
>
> -Goroutines communicate via channels. A channel is a typed conduit, like a
> Unix pipe. Channels may be synchronous (unbuffered) or asynchronous
> (buffered).
> +Goroutines communicate via channels. A channel is a typed conduit that
> may be synchronous (unbuffered) or asynchronous (buffered).
>
> .play chat/support/chan.go
>
> @@ -266,7 +266,7 @@
> * Integrating the markov bot
>
> The bot should jump in if a real partner doesn't join.
> -To do this, we add a case to the select that triggers after 10 seconds,
> starting a chat between the user's socket and a bot.
> +To do this, we add a case to the select that triggers after 5 seconds,
> starting a chat between the user's socket and a bot.
>
> .code chat/markov/chat.go /func.match/,/^}/
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>
*** Submitted as https://code.google.com/p/go/source/detail?r=fec9d4007e12&repo=talks *** go.talks/2012/chat: some minor cleanups R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/8695050
Issue 8695050: code review 8695050: go.talks/2012/chat: some minor cleanups
(Closed)
Created 11 years ago by adg
Modified 11 years ago
Reviewers:
Base URL:
Comments: 0